CLID-476: Fixes for cross-build errors

[dorzel]

Description

I noticed when cross-building for ppc64le that make was erroring while trying to pass GO_BUILD_FLAGS as positional arguments. Cross-builds were also failing with CGO due to unknown ASM instructions while translating the assembly.

Also set GO_BUILD_BINDIR in the build step so one can run cross-builds first, without having already run make build. (It was assuming v1/bin/oc-mirror existed regardless of the value of GO_BUILD_BINDIR).

Github / Jira issue:

None

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Code Improvements (Refactoring, Performance, CI upgrades, etc)
• Internal repo assets (diagrams / docs on github repo)
• This change requires a documentation update on openshift docs

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

make clean
make tidy
make cross-build
make build

Expected Outcome

Please describe the outcome expected from the tests.

cross-builds properly build and populate /bin without errors.

[aguidirh]

Hi @dorzel,

Thanks for the PR. I tested make cross-build and it worked fine as expected.

I added only one concern I have to the PR.

[aguidirh]

Hi @dorzel,

My only concern about disabling CGO is the FIPS.

For RHEL9 we build a FIPS compliance binary which requires CGO_ENABLED=1.

What do you think about it @r4f4?

[dorzel]

@aguidirh Ah I see, if it is an issue I can try to modify this to work with CGO enabled as well.

[openshift-ci-robot]

@dorzel: This pull request references CLID-476 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

Description

I noticed when cross-building for ppc64le that make was erroring while trying to pass GO_BUILD_FLAGS as positional arguments. Cross-builds were also failing with CGO due to unknown ASM instructions while translating the assembly.

Also set GO_BUILD_BINDIR in the build step so one can run cross-builds first, without having already run make build. (It was assuming v1/bin/oc-mirror existed regardless of the value of GO_BUILD_BINDIR).

Github / Jira issue:

None

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Code Improvements (Refactoring, Performance, CI upgrades, etc)
• Internal repo assets (diagrams / docs on github repo)
• This change requires a documentation update on openshift docs

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

make clean
make tidy
make cross-build
make build

Expected Outcome

Please describe the outcome expected from the tests.

cross-builds properly build and populate /bin without errors.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[dorzel]

/jira refresh

[openshift-ci-robot]

@dorzel: This pull request references CLID-476 which is a valid jira issue.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[dorzel]

Ok, I think the latest changes solve it nicely. The conditional assignment allows for:

• preserving all default CGO behavior (due to not exporting the variable)
• defaulting cross-build targets to CGO_ENABLED=0 (makefile is not "broken" by default for standard users)
• overrides for CGO_ENABLED passed via CLI are favored for all targets

[dorzel]

/retest

[dorzel]

/test v1-e2e

[dorzel]

/retest

[openshift-ci]

@dorzel: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[aguidirh]

Thanks @dorzel for taking into account the suggestions.

I ran some tests and it worked as expected on my side.

I will approve and let LGTM to @r4f4.

[aguidirh]

nit: it would be nice to add in the comment the reason why it is needed to disable CGO for cross-builds.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aguidirh, dorzel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [aguidirh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment