Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "OCPBUGS-32108: stop loading legacy schemes on global scheme " #1805

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dgoodwin
Copy link

Reverts #1775

This will not be merged, we're trying to find a PR that fixed something which is still happening in 4.16. This PR is in the list of 4 when the problem dissappeared in 4.17.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 24, 2024
@openshift-ci-robot
Copy link

@dgoodwin: This pull request references Jira Issue OCPBUGS-32108, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Reverts #1775

This will not be merged, we're trying to find a PR that fixed something which is still happening in 4.16. This PR is in the list of 4 when the problem dissappeared in 4.17.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dgoodwin
Copy link
Author

/payload-job periodic-ci-openshift-release-master-ci-4.17-e2e-gcp-ovn
/payload-job periodic-ci-openshift-release-master-ci-4.17-e2e-gcp-ovn
/payload-job periodic-ci-openshift-release-master-ci-4.17-e2e-gcp-ovn

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 24, 2024
Copy link
Contributor

openshift-ci bot commented Jun 24, 2024

@dgoodwin: trigger 3 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.17-e2e-gcp-ovn
  • periodic-ci-openshift-release-master-ci-4.17-e2e-gcp-ovn
  • periodic-ci-openshift-release-master-ci-4.17-e2e-gcp-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/8d29bcf0-3250-11ef-984e-78501d802096-0

@openshift-ci openshift-ci bot requested review from deads2k and soltysh June 24, 2024 17:43
Copy link
Contributor

openshift-ci bot commented Jun 24, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dgoodwin
Once this PR has been reviewed and has the lgtm label, please assign ardaguclu for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rphillips
Copy link
Contributor

Maybe try this once more... Looks like a CI issue.

/payload-job periodic-ci-openshift-release-master-ci-4.17-e2e-gcp-ovn
/payload-job periodic-ci-openshift-release-master-ci-4.17-e2e-gcp-ovn
/payload-job periodic-ci-openshift-release-master-ci-4.17-e2e-gcp-ovn

Copy link
Contributor

openshift-ci bot commented Jun 24, 2024

@rphillips: trigger 3 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.17-e2e-gcp-ovn
  • periodic-ci-openshift-release-master-ci-4.17-e2e-gcp-ovn
  • periodic-ci-openshift-release-master-ci-4.17-e2e-gcp-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/19f8aa20-3264-11ef-9ac3-35a367096689-0

@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 23, 2024
@openshift-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants