Include must-gather image name in ENV #1842
Conversation
The request for such feature came from a Bugzilla for odf-must-gather. We want the must-gather containers to be able to check the image being used. This is useful in cases where we want to deduce if the customer is using the image we ask them to. While it is possible to call the k8s API internally (this is how it is implemented currently for odf-mg), it would be much efficient if the value is present inside the container as an ENV. This patch sets an ENV var `MUST_GATHER_IMAGE` to reflect the image source of the pods. Signed-off-by: Niraj Yadav <niryadav@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: black-dragon74 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@black-dragon74: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
PTAL @ardaguclu @soltysh |
The request for such feature came from a Bugzilla
for odf-must-gather.
We want the must-gather containers to be able to check the image being used. This is useful in cases where we want to deduce if the customer is using the image we ask them to.
While it is possible to call the k8s API internally (this is how it is implemented currently for odf-mg), it would be much efficient if the value is present inside the container as an ENV.
This patch sets an ENV var
MUST_GATHER_IMAGEto reflect the image source of the pods.Regards