Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding plugin handler test makefile target #3787

Conversation

prietyc123
Copy link
Contributor

@prietyc123 prietyc123 commented Aug 19, 2020

What type of PR is this?

/kind feature

What does does this PR do / why we need it:

$SUBJECT It was missed in the make target. To run the individual target we need it.

Which issue(s) this PR fixes:

Fixes NA

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

make test-plugin-handler as well as make test-integration should run

@openshift-ci-robot openshift-ci-robot added the kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation label Aug 19, 2020
@amitkrout
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Aug 20, 2020
@prietyc123
Copy link
Contributor Author

/retest

@girishramnani
Copy link
Contributor

Is it present in .travis.yaml?

@prietyc123
Copy link
Contributor Author

Is it present in .travis.yaml?

No, I didn't find any. Let me add it to travis as well 👍

@girishramnani
Copy link
Contributor

Cool

Copy link
Contributor

@amitkrout amitkrout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the test target in travis CI

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Aug 20, 2020
@amitkrout
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Aug 20, 2020
@girishramnani
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: girishramnani

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Aug 20, 2020
@codecov
Copy link

codecov bot commented Aug 20, 2020

Codecov Report

Merging #3787 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3787      +/-   ##
==========================================
+ Coverage   44.15%   44.19%   +0.04%     
==========================================
  Files         139      139              
  Lines       13345    13388      +43     
==========================================
+ Hits         5892     5917      +25     
- Misses       6874     6888      +14     
- Partials      579      583       +4     
Impacted Files Coverage Δ
pkg/devfile/parser/parse.go 53.84% <0.00%> (-2.09%) ⬇️
pkg/testingutil/devfile.go 0.00% <0.00%> (ø)
pkg/devfile/parser/types.go 70.21% <0.00%> (+1.38%) ⬆️
pkg/devfile/parser/data/2.0.0/components.go 39.03% <0.00%> (+2.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eec93d3...362c663. Read the comment docs.

@openshift-merge-robot openshift-merge-robot merged commit 32a8454 into redhat-developer:master Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants