clean up devfile env tests and uses dns supported component name #3793
Conversation
| @@ -10,9 +10,9 @@ import ( | |||
| "github.com/openshift/odo/tests/helper" | |||
| ) | |||
|
|
|||
| var _ = Describe("odo devfile env command tests", func() { | |||
| var _ = FDescribe("odo devfile env command tests", func() { | |||
| @@ -10,9 +10,9 @@ import ( | |||
| "github.com/openshift/odo/tests/helper" | |||
| ) | |||
|
|
|||
| var _ = Describe("odo devfile env command tests", func() { | |||
| var _ = FDescribe("odo devfile env command tests", func() { | |||
There was a problem hiding this comment.
hehe, resolved
| @@ -81,26 +81,6 @@ var _ = Describe("odo devfile env command tests", func() { | |||
| testDebugPort, | |||
| } | |||
| helper.MatchAllInOutput(output, wantOutput) | |||
| }) | |||
|
|
|||
| It("Should fail to set the invalid parameter", func() { | |||
There was a problem hiding this comment.
Its good to keep a negative case for validation.
There was a problem hiding this comment.
There was a problem hiding this comment.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amitkrout The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
looks good to me /lgtm |
openshift-ci-robot
added
the
lgtm
Codecov Report
@@ Coverage Diff @@
## master #3793 +/- ##
=======================================
Coverage 44.19% 44.19%
=======================================
Files 139 139
Lines 13388 13388
=======================================
Hits 5917 5917
Misses 6888 6888
Partials 583 583 Continue to review full report at Codecov.
|
|
/refresh |
What type of PR is this?
/kind cleanup
What does does this PR do / why we need it:
clean up devfile env tests and uses dns supported component name
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer: