-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove showing help twice for incorrect commands #3805
remove showing help twice for incorrect commands #3805
Conversation
@girishramnani Can you please attach the screenshot or text output of before and after change. I am asking because it's a UX change, so output before and after would really be helpful. |
/retest |
Before
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mik-dass The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #3805 +/- ##
==========================================
+ Coverage 44.19% 44.27% +0.07%
==========================================
Files 139 139
Lines 13388 13405 +17
==========================================
+ Hits 5917 5935 +18
Misses 6888 6888
+ Partials 583 582 -1
Continue to review full report at Codecov.
|
What type of PR is this?
/kind bug
What does does this PR do / why we need it:
see $SUBJECT
Which issue(s) this PR fixes:
Fixes #3750
PR acceptance criteria:
Unit test
Integration test
Documentation
I have read the test guidelines
How to test changes / Special notes to the reviewer:
should only print help once