Fixing rvm error and Docker file format for travis login #3813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
kind/bug
Codecov Report
@@ Coverage Diff @@
## master #3813 +/- ##
=======================================
Coverage 44.27% 44.27%
=======================================
Files 139 139
Lines 13405 13405
=======================================
Hits 5935 5935
Misses 6888 6888
Partials 582 582 Continue to review full report at Codecov.
|
|
/lgtm |
openshift-ci-robot
added
the
lgtm
|
NOTE: Changes does not break the master |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mohammedzee1000 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What does does this PR do / why we need it:
https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_release/10942/rehearse-10942-pull-ci-openshift-odo-master-macOS-testmasoshost/1297231399283068928#1:build-log.txt%3A280
Which issue(s) this PR fixes:
Fixes - It will fix the docker build issue for pr openshift/release#10942
PR acceptance criteria:
Unit test : NA
Integration test : NA
Documentation : NA
I have read the test guidelines
How to test changes / Special notes to the reviewer:
pr openshift/release#10942 should not fail with
error: build error: running 'rvm requirements run' failed with exit code 127