Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update s2i image from library for ppc64le #3939

Merged
merged 1 commit into from
Sep 14, 2020
Merged

Update s2i image from library for ppc64le #3939

merged 1 commit into from
Sep 14, 2020

Conversation

sarveshtamba
Copy link
Contributor

What type of PR is this?
/kind bug

What does does this PR do / why we need it:
Similar to PR #3873 . The upstream library updated the link for s2i imagestreams. There are errors when running odo ci script on OCP/P. Errors of following types are observed.

++ oc apply -n openshift -f https://raw.githubusercontent.com/openshift/library/master/community/dotnet/imagestreams/dotnet-centos7.json
error: unable to read URL "https://raw.githubusercontent.com/openshift/library/master/community/dotnet/imagestreams/dotnet-centos7.json", server reported 404 Not Found, status code=404
++ sleep 15
++ oc annotate istag/dotnet:latest --namespace=openshift tags=builder --overwrite
Error from server (NotFound): imagestreamtags.image.openshift.io "dotnet" not found

Which issue(s) this PR fixes:

Fixes #?

PR acceptance criteria:

How to test changes / Special notes to the reviewer:

Update s2i image from library for ppc64le
@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Sep 11, 2020
@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. Required by Prow. label Sep 11, 2020
@openshift-ci-robot
Copy link
Collaborator

Hi @sarveshtamba. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sarveshtamba
Copy link
Contributor Author

/area system-pz

@openshift-ci-robot openshift-ci-robot added the area/System-PZ Issues related to IBM System Z and System P label Sep 11, 2020
@johnmcollier
Copy link
Member

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. Required by Prow. labels Sep 11, 2020
@sarveshtamba
Copy link
Contributor Author

/retest

3 similar comments
@sarveshtamba
Copy link
Contributor Author

/retest

@sarveshtamba
Copy link
Contributor Author

/retest

@sarveshtamba
Copy link
Contributor Author

/retest

@openshift-ci-robot
Copy link
Collaborator

@sarveshtamba: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/v4.5-integration-e2e a4dba09 link /test v4.5-integration-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sarveshtamba
Copy link
Contributor Author

/retest

1 similar comment
@sarveshtamba
Copy link
Contributor Author

/retest

@amitkrout
Copy link
Contributor

/approve
/lgtm

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amitkrout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. Required by Prow. approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. labels Sep 14, 2020
@amitkrout
Copy link
Contributor

one word change and does not affect the prow CI
/override v4.5-integration-e2e

@openshift-ci-robot
Copy link
Collaborator

@amitkrout: /override requires a failed status context to operate on.
The following unknown contexts were given:

  • v4.5-integration-e2e

Only the following contexts were expected:

  • ci/prow/unit
  • ci/prow/v4.5-integration-e2e
  • tide

In response to this:

one word change and does not affect the prow CI
/override v4.5-integration-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@amitkrout amitkrout merged commit f535cb9 into redhat-developer:master Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. area/System-PZ Issues related to IBM System Z and System P kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. Required by Prow. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants