Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prints help message based on backend cluster #3993

Merged
merged 1 commit into from
Sep 21, 2020
Merged

Prints help message based on backend cluster #3993

merged 1 commit into from
Sep 21, 2020

Conversation

dharmit
Copy link
Member

@dharmit dharmit commented Sep 21, 2020

What type of PR is this?

/kind bug

What does does this PR do / why we need it:
It fixes bug wherein odo link -h prints same help message for both 3.x & 4.x clusters

Which issue(s) this PR fixes:

Fixes #3992

PR acceptance criteria:

How to test changes / Special notes to the reviewer:
Check odo link -h by logging into OCP 3.x & 4.x clusters.

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Sep 21, 2020
@adisky
Copy link
Contributor

adisky commented Sep 21, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Sep 21, 2020
Copy link
Contributor

@mik-dass mik-dass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mik-dass

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Sep 21, 2020
@openshift-merge-robot openshift-merge-robot merged commit 9cde4dc into redhat-developer:master Sep 21, 2020
@dharmit dharmit deleted the fix-3992 branch January 7, 2021 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"odo link -h" shows same message for 3.x & 4.x clusters
5 participants