Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update integration testcases and e2e testcases for ppc64le support #4000

Merged
merged 2 commits into from
Sep 24, 2020
Merged

Conversation

sarveshtamba
Copy link
Contributor

What type of PR is this?
/kind feature

What does does this PR do / why we need it:
Update integration testcases and e2e testcases for ppc64le support after testing on Power system.

Which issue(s) this PR fixes:

Fixes #?

PR acceptance criteria:

How to test changes / Special notes to the reviewer:

@openshift-ci-robot openshift-ci-robot added the kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation label Sep 21, 2020
@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. Required by Prow. label Sep 21, 2020
@openshift-ci-robot
Copy link
Collaborator

Hi @sarveshtamba. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sarveshtamba
Copy link
Contributor Author

/assign @amitkrout

@amitkrout
Copy link
Contributor

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. Required by Prow. labels Sep 21, 2020
@sarveshtamba
Copy link
Contributor Author

/retest

@codecov
Copy link

codecov bot commented Sep 22, 2020

Codecov Report

Merging #4000 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4000   +/-   ##
=======================================
  Coverage   43.17%   43.17%           
=======================================
  Files         146      146           
  Lines       12338    12338           
=======================================
  Hits         5327     5327           
  Misses       6445     6445           
  Partials      566      566           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cde4dc...d0ff131. Read the comment docs.

@sarveshtamba
Copy link
Contributor Author

/retest

@amitkrout
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amitkrout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Sep 23, 2020
@prietyc123
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Sep 23, 2020
@sarveshtamba
Copy link
Contributor Author

/retest

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Sep 24, 2020
@prietyc123
Copy link
Contributor

@sarveshtamba Please address the requested change until then I am holding this pr

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. label Sep 24, 2020
Copy link
Contributor Author

@sarveshtamba sarveshtamba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provided respective comments explaining the changes.

tests/e2escenarios/e2e_source_test.go Show resolved Hide resolved
tests/e2escenarios/e2e_source_test.go Show resolved Hide resolved
tests/e2escenarios/e2e_source_test.go Show resolved Hide resolved
@prietyc123
Copy link
Contributor

As discussed on slack, it seems this pr is blocker for the system P-Z team and it should go in before 2.0 release freeze. So I will do the clean up part later.

/unhold
/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. Required by Prow. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. labels Sep 24, 2020
@sarveshtamba
Copy link
Contributor Author

/retest

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit fe982a0 into redhat-developer:master Sep 24, 2020
@sarveshtamba
Copy link
Contributor Author

/area system-pz

@openshift-ci-robot openshift-ci-robot added the area/System-PZ Issues related to IBM System Z and System P label Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. area/System-PZ Issues related to IBM System Z and System P kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation lgtm Indicates that a PR is ready to be merged. Required by Prow. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants