-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nit: dont show url as :// in odo url list #4111
nit: dont show url as :// in odo url list #4111
Conversation
Not working for me on a Openshift cluster It works for s2i components though
|
Same here on CRC.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$ odo url list
Found the following URLs for component nodetodo
NAME STATE URL PORT SECURE KIND
http-3000 Not Pushed 3000 false route
Works for me!
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dharmit The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -111,9 +112,11 @@ var _ = Describe("odo devfile url command tests", func() { | |||
|
|||
helper.CopyExample(filepath.Join("source", "devfiles", "nodejs", "project"), commonVar.Context) | |||
helper.CopyExampleDevFile(filepath.Join("source", "devfiles", "nodejs", "devfile.yaml"), filepath.Join(commonVar.Context, "devfile.yaml")) | |||
|
|||
helper.CmdShouldPass("odo", "url", "create", url1, "--host", host, "--ingress") | |||
// we check the default url | |||
stdout := helper.CmdShouldPass("odo", "url", "list") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will fail on a kubernetes cluster
[odo] ✗ no URLs found for component rgsrbu. Refer `odo url create -h` to add one
Deleting project: gqpnssmcal
Running kubectl with args [kubectl delete namespaces gqpnssmcal]
[kubectl] namespace "gqpnssmcal" deleted
Setting current dir to: /home/travis/gopath/src/github.com/openshift/odo/tests/integration/devfile
https://travis-ci.com/github/openshift/odo/jobs/399332372#L1459
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved
45b7d2c
to
e20001e
Compare
Codecov Report
|
/refresh |
Still cannot see tidy on this PR |
/retest |
1 similar comment
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
What type of PR is this?
/kind bug
What does does this PR do / why we need it:
before doing odo push if there is a url present then we show it as
://
and that's confusing. Resolved it by making it a blank until user pushes.Which issue(s) this PR fixes:
Fixes #4109
PR acceptance criteria:
Unit test
Integration test
Documentation
I have read the test guidelines
How to test changes / Special notes to the reviewer:
way to reproduce
Output:
After fix the url would be blank