Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update required s2i imagestreams for nodejs and java on IBM Z. #4180

Merged

Conversation

zhengxiaomei123
Copy link
Contributor

@zhengxiaomei123 zhengxiaomei123 commented Nov 2, 2020

What type of PR is this?
/kind bug
What does does this PR do / why we need it:
To update the required s2i imagestream for nodejs and java application.

PR acceptance criteria:

How to test changes / Special notes to the reviewer:

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Nov 2, 2020
@zhengxiaomei123
Copy link
Contributor Author

/area system-pz

@openshift-ci-robot openshift-ci-robot added the area/System-PZ Issues related to IBM System Z and System P label Nov 2, 2020
@jichenjc
Copy link
Contributor

jichenjc commented Nov 2, 2020

@zhengxiaomei123 can you help to provide an issue about the update purpose?

@zhengxiaomei123
Copy link
Contributor Author

zhengxiaomei123 commented Nov 2, 2020

@zhengxiaomei123 can you help to provide an issue about the update purpose?

@jichenjc Just update the s2i imagestream, there is no issue opened for it.

Copy link
Contributor

@mohammedzee1000 mohammedzee1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Nov 2, 2020
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mohammedzee1000

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Nov 2, 2020
@codecov
Copy link

codecov bot commented Nov 2, 2020

Codecov Report

Merging #4180 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4180   +/-   ##
=======================================
  Coverage   42.28%   42.28%           
=======================================
  Files         154      154           
  Lines       13074    13074           
=======================================
  Hits         5528     5528           
  Misses       6954     6954           
  Partials      592      592           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa4c528...3682164. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. area/System-PZ Issues related to IBM System Z and System P kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants