-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update required s2i imagestreams for nodejs and java on IBM Z. #4180
Update required s2i imagestreams for nodejs and java on IBM Z. #4180
Conversation
/area system-pz |
@zhengxiaomei123 can you help to provide an issue about the update purpose? |
@jichenjc Just update the s2i imagestream, there is no issue opened for it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mohammedzee1000 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #4180 +/- ##
=======================================
Coverage 42.28% 42.28%
=======================================
Files 154 154
Lines 13074 13074
=======================================
Hits 5528 5528
Misses 6954 6954
Partials 592 592 Continue to review full report at Codecov.
|
What type of PR is this?
/kind bug
What does does this PR do / why we need it:
To update the required s2i imagestream for nodejs and java application.
PR acceptance criteria:
Unit test
Integration test
Documentation
I have read the test guidelines
How to test changes / Special notes to the reviewer: