Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nit: remove the 'Devfile path' log even when using --s2i in odo create --context #4182

Merged

Conversation

girishramnani
Copy link
Contributor

@girishramnani girishramnani commented Nov 2, 2020

What type of PR is this?

Uncomment only one /kind line, and delete the rest.
For example, > /kind bug would simply become: /kind bug
/kind cleanup

What does does this PR do / why we need it:
see $SUBJECT

Which issue(s) this PR fixes:

No issue

PR acceptance criteria:

How to test changes / Special notes to the reviewer:

  • Before :
~ odo create --s2i nodejs --context ./import2
Devfile path: 
Validation
 ✓  Validating component [429ms]

Please use `odo push` command to create the component with source deployed
  • After :
~ odo create --s2i nodejs --context ./import
Validation
 ✓  Validating component [429ms]

Please use `odo push` command to create the component with source deployed

@codecov
Copy link

codecov bot commented Nov 3, 2020

Codecov Report

Merging #4182 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4182   +/-   ##
=======================================
  Coverage   42.28%   42.28%           
=======================================
  Files         154      154           
  Lines       13074    13074           
=======================================
  Hits         5528     5528           
  Misses       6954     6954           
  Partials      592      592           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b33adbc...7616044. Read the comment docs.

Copy link
Member

@dharmit dharmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Nov 3, 2020
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dharmit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Nov 3, 2020
@openshift-merge-robot openshift-merge-robot merged commit 1f15a2c into redhat-developer:master Nov 3, 2020
kadel pushed a commit to prietyc123/odo that referenced this pull request Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants