Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactors and moves buildConfigs, imageStreams and some other resources #4261

Merged
merged 1 commit into from
Dec 1, 2020
Merged

Refactors and moves buildConfigs, imageStreams and some other resources #4261

merged 1 commit into from
Dec 1, 2020

Conversation

mik-dass
Copy link
Contributor

@mik-dass mik-dass commented Nov 26, 2020 •
edited
Loading

What type of PR is this?

/kind code-refactoring
/kind cleanup

What does does this PR do / why we need it:

Refactors and moves buildConfigs, imageStreams and some other resources like deployments etc into new files or existing files.

Which issue(s) this PR fixes:

Fixes part of #4093

PR acceptance criteria:

How to test changes / Special notes to the reviewer:

  • Tests should pass.

@mik-dass
Refactors and moves buildConfigs and imageStreams related code into n…
835ea74 
…ew files.

It also refactors a few other resources like deployment etc.

Signed-off-by: mik-dass <mrinald7@gmail.com>
@mik-dass
Copy link
Contributor Author 

[odo]  ✗  Waiting for component to start [5m]
[odo]  ✗  Failed to start component with name yhjtpr. Error: Failed to create the component: error while waiting for deployment rollout: timeout while waiting for yhjtpr deployment roll out
Deleting project: afzsefccet

/retest

@dharmit
Copy link
Member

dharmit commented Nov 27, 2020 

[odo]  ✗  Waiting for component to start [5m]
[odo]  ✗  Failed to start component with name yhjtpr. Error: Failed to create the component: error while waiting for deployment rollout: timeout while waiting for yhjtpr deployment roll out
Deleting project: afzsefccet

/retest

Looks like #3256.

@dharmit
Copy link
Member

dharmit commented Nov 30, 2020 •
edited
Loading

Once again the CI's failing on:

[odo]  ✗  Waiting for component to start [5m]
[odo]  ✗  Failed to start component with name fcaivh. Error: Failed to create the component: error while waiting for deployment rollout: timeout while waiting for fcaivh deployment roll out
Deleting project: mpvdkbglsm

#3256 😞

dharmit
dharmit approved these changes Nov 30, 2020
View reviewed changes
Copy link
Member

@dharmit dharmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Nov 30, 2020
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dharmit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Nov 30, 2020
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit cdfa545 into redhat-developer:master Dec 1, 2020
@mik-dass mik-dass deleted the refactor_oc_kube_client branch December 1, 2020 05:47
@mik-dass mik-dass mentioned this pull request Dec 4, 2020
Closed
1 task
@anandrkskd anandrkskd mentioned this pull request Dec 16, 2020
Closed
@rm3l rm3l added the area/refactoring Issues or PRs related to code refactoring label Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dharmit dharmit dharmit approved these changes

@mohammedzee1000 mohammedzee1000 Awaiting requested review from mohammedzee1000

Assignees

@dharmit dharmit

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. area/refactoring Issues or PRs related to code refactoring lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mik-dass @dharmit @openshift-ci-robot @openshift-bot @rm3l @openshift-merge-robot