Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactors service catalog and discovery client code #4272

Conversation

mik-dass
Copy link
Contributor

@mik-dass mik-dass commented Dec 2, 2020

What type of PR is this?

/kind cleanup
/kind code-refactoring

What does does this PR do / why we need it:

Refactors service catalog and discovery client code and moves them into the kclient package. It also refactors the operator code.

Which issue(s) this PR fixes:

Fixes part of #4093

PR acceptance criteria:

How to test changes / Special notes to the reviewer:

  • Tests should pass.

…to the kclient package.

It also refactors the operator code.
@mik-dass mik-dass force-pushed the refactor_service_catalog_discovery branch from 99cc1ca to 624a51a Compare December 2, 2020 07:32
Copy link
Member

@dharmit dharmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested a really minor change in operators.go

pkg/kclient/operators.go Outdated Show resolved Hide resolved
@adisky
Copy link
Contributor

adisky commented Dec 3, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Dec 3, 2020
Copy link
Member

@dharmit dharmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dharmit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Dec 3, 2020
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit bf6b1b4 into redhat-developer:master Dec 3, 2020
@mik-dass mik-dass deleted the refactor_service_catalog_discovery branch December 4, 2020 02:48
@rm3l rm3l added the area/refactoring Issues or PRs related to code refactoring label Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. area/refactoring Issues or PRs related to code refactoring lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants