Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove packages imported twice #4275

Merged

Conversation

girishramnani
Copy link
Contributor

What type of PR is this?
/kind cleanup

What does does this PR do / why we need it:
See $SUBJECT

Which issue(s) this PR fixes:

Cleaning up code

PR acceptance criteria:

How to test changes / Special notes to the reviewer:
All tests should pass no new functionality was added

@girishramnani
Copy link
Contributor Author

/retest

@dharmit
Copy link
Member

dharmit commented Dec 3, 2020

level=error
level=error msg="Error: Error creating VPC: VpcLimitExceeded: The maximum number of VPCs has been reached."
level=error msg="\tstatus code: 400, request id: 9fb00ad4-f954-4f61-b08f-3e03428b8f20"
level=error
level=error msg="  on ../tmp/openshift-install-244746410/vpc/vpc.tf line 6, in resource \"aws_vpc\" \"new_vpc\":"
level=error msg="   6: resource \"aws_vpc\" \"new_vpc\" {"
level=error
level=error
level=fatal msg="failed to fetch Cluster: failed to generate asset \"Cluster\": failed to create cluster: failed to apply Terraform: failed to complete the change"
2020/12/02 15:21:46 Failed to upload $KUBECONFIG: timed out waiting for the condition: stat /tmp/secret/kubeconfig: no such file or directory
error: failed to execute wrapped command: exit status 1 

Copy link
Contributor

@adisky adisky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since they are only lint checks doing both
/approve
/lgtm

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adisky

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. Required by Prow. approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. labels Dec 3, 2020
@openshift-merge-robot openshift-merge-robot merged commit 529a1bd into redhat-developer:master Dec 3, 2020
@rm3l rm3l added the area/refactoring Issues or PRs related to code refactoring label Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. area/refactoring Issues or PRs related to code refactoring lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants