Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactors URL for localConfigProvider. #4311

Merged
merged 3 commits into from
Jan 4, 2021
Merged

Refactors URL for localConfigProvider. #4311

merged 3 commits into from
Jan 4, 2021

Conversation

mik-dass
Copy link
Contributor

@mik-dass mik-dass commented Dec 15, 2020 •
edited
Loading

What type of PR is this?

/kind cleanup
/kind code-refactoring

What does does this PR do / why we need it:

The CLI layer code for url create and delete are refactored to use the new changes.

It also moves the localConfigProvider to a new package.

Which issue(s) this PR fixes:

Fixes part of #4298

PR acceptance criteria:

How to test changes / Special notes to the reviewer:

  • Tests should pass.

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. kind/cleanup labels Dec 15, 2020
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mik-dass

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Dec 15, 2020
@mik-dass mik-dass marked this pull request as draft December 15, 2020 09:06
@mik-dass mik-dass marked this pull request as ready for review December 15, 2020 14:53
@mik-dass mik-dass force-pushed the local_url_refactor branch 5 times, most recently from c6be268 to c397109 Compare December 16, 2020 13:48
@mik-dass mik-dass changed the title [WIP] Refactors URL for localConfigProvider. Refactors URL for localConfigProvider. Dec 16, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Dec 16, 2020
@mik-dass
Refactors URL for localConfigProvider. The CLI layer code for url cre…
4f29706 
…ate and delete are refactored to use the new changes.

It also moves the localConfigProvider to a new package.

Signed-off-by: mik-dass <mrinald7@gmail.com>
@openshift-merge-robot
Copy link
Collaborator

@mik-dass: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/v4.6-integration-e2e 4f29706 link /test v4.6-integration-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

dharmit
dharmit suggested changes Dec 22, 2020
View reviewed changes
Copy link
Member

@dharmit dharmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only reviewed the odo url create on CRC so far.

pkg/config/url.go Outdated Show resolved Hide resolved
pkg/config/url.go Show resolved Hide resolved
pkg/odo/cli/url/create.go Outdated Show resolved Hide resolved
pkg/odo/cli/url/create.go Show resolved Hide resolved
pkg/odo/genericclioptions/context.go Outdated Show resolved Hide resolved
pkg/localConfigProvider/localConfigProvider.go Show resolved Hide resolved
pkg/envinfo/url.go Show resolved Hide resolved
pkg/envinfo/url.go Show resolved Hide resolved
pkg/envinfo/url.go Outdated Show resolved Hide resolved
pkg/envinfo/url.go Outdated Show resolved Hide resolved
dharmit
dharmit suggested changes Dec 29, 2020
View reviewed changes
pkg/odo/genericclioptions/context.go Outdated Show resolved Hide resolved
pkg/odo/cli/url/create.go Show resolved Hide resolved
@dharmit
Copy link
Member

dharmit commented Dec 29, 2020 •
edited
Loading

@mik-dass few more questions/requests. Also, it seems that you missed a few things from previous review although you've mentioned fixed.

Looks good otherwise. Thanks for the effort. 👍

@dharmit dharmit mentioned this pull request Dec 30, 2020
Merged
4 tasks
@mik-dass
Renames URLCreateOptions and URLDeleteOptions to CreateOptions and De…
b337c7d 
…leteOptions.

Also simplifies the logic during context creation and fixes the comment for the LocalConfigProvider interface.
@dharmit dharmit mentioned this pull request Jan 4, 2021
Closed
dharmit
dharmit approved these changes Jan 4, 2021
View reviewed changes
Copy link
Member

@dharmit dharmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jan 4, 2021
@openshift-merge-robot openshift-merge-robot merged commit 526ce0a into redhat-developer:master Jan 4, 2021
@mik-dass mik-dass deleted the local_url_refactor branch January 4, 2021 12:29
@rm3l rm3l added the area/refactoring Issues or PRs related to code refactoring label Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dharmit dharmit dharmit approved these changes

@adisky adisky Awaiting requested review from adisky

@mohammedzee1000 mohammedzee1000 Awaiting requested review from mohammedzee1000

Assignees

@dharmit dharmit

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. area/refactoring Issues or PRs related to code refactoring lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mik-dass @openshift-ci-robot @openshift-merge-robot @dharmit @rm3l