Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some fix for configure script of s390x. #4317

Merged
merged 1 commit into from
Jan 20, 2021
Merged

Some fix for configure script of s390x. #4317

merged 1 commit into from
Jan 20, 2021

Conversation

zhengxiaomei123
Copy link
Contributor

@zhengxiaomei123 zhengxiaomei123 commented Dec 18, 2020 •
edited
Loading

What type of PR is this?
/kind bug
/kind failing-test

What does does this PR do / why we need it:
Add same fix with #4206.
Add some fix for importing java imagestream.
Which issue(s) this PR fixes:

Fixes #?

PR acceptance criteria:

How to test changes / Special notes to the reviewer:

@zhengxiaomei123
Copy link
Contributor Author

/area system-PZ

@openshift-ci-robot openshift-ci-robot added the area/System-PZ Issues related to IBM System Z and System P label Dec 18, 2020
@openshift-merge-robot
Copy link
Collaborator

@zhengxiaomei123: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/v4.6-integration-e2e f5fcdc1 link /test v4.6-integration-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rnapoles-rh
Copy link
Contributor

@zhengxiaomei123 integration tests failed.

@zhengxiaomei123
Copy link
Contributor Author

/retest

@dharmit
Copy link
Member

dharmit commented Dec 21, 2020

@prietyc123 @mohammedzee1000 this PR is modifying the cluster configuration script for s390x architecture. But the 4.6 tests that are failing are being run on x86, right? What I'm observing in the test failures is that odo catalog list services command is failing in Operator Hub integration tests because it can't find any Operators installed on the cluster.

In this PR, I'm seeing that KUBEADMIN_PASSWORD value is being removed from configuration script of s390x: https://github.com/openshift/odo/pull/4317/files#diff-e24df2f816e33c2abe791ad856ac6f922a218705363d4f3176ec5e12050b5cb2L103-L106. But why would that cause failures in our integration tests that are running on x86? That should use configure-installer-tests-cluster.sh script, no?

@mohammedzee1000
Copy link
Contributor

Interesting, that should not affect x86 indeed,

mohammedzee1000
mohammedzee1000 approved these changes Jan 11, 2021
View reviewed changes
Copy link
Contributor

@mohammedzee1000 mohammedzee1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me codewise
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jan 11, 2021
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jan 11, 2021
@rnapoles-rh
Copy link
Contributor

@zhengxiaomei123 also wondering why the sleep 5 is needed.

@prietyc123
Copy link
Contributor

Failing due to #4301 .

/retest

@prietyc123
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jan 13, 2021
@rnapoles-rh
Copy link
Contributor

/lgtm

@zhengxiaomei123
Copy link
Contributor Author

/retest

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jan 15, 2021
@zhengxiaomei123
Add same fix with redhat-developer#4206.
cd1c5ee 
Add some fix for importing java imagestream.
@rnapoles-rh
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jan 18, 2021
@girishramnani
Copy link
Contributor

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Jan 19, 2021
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@rnapoles-rh
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: girishramnani, rnapoles-rh, zhengxiaomei123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 5544b25 into redhat-developer:master Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dharmit dharmit dharmit left review comments

@prietyc123 prietyc123 prietyc123 requested changes

@mohammedzee1000 mohammedzee1000 mohammedzee1000 approved these changes

@rnapoles-rh rnapoles-rh rnapoles-rh approved these changes

Assignees

@mohammedzee1000 mohammedzee1000

@prietyc123 prietyc123

@rnapoles-rh rnapoles-rh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. area/System-PZ Issues related to IBM System Z and System P lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@zhengxiaomei123 @openshift-merge-robot @rnapoles-rh @dharmit @mohammedzee1000 @prietyc123 @girishramnani @openshift-bot @openshift-ci-robot