Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Execute make target consecutively even on failure #4324

Merged
merged 3 commits into from
Dec 24, 2020
Merged

Execute make target consecutively even on failure #4324

merged 3 commits into from
Dec 24, 2020

Conversation

prietyc123
Copy link
Contributor

@prietyc123 prietyc123 commented Dec 21, 2020 •
edited
Loading

What type of PR is this?

/kind feature

What does does this PR do / why we need it:

This PR enables the next make target execution even if the the existing one fails. For ex - If make test-integration fails It won't fail the overall execution, instead start the next make target execution.

Which issue(s) this PR fixes:

Fixes NA (Interop team has particularly urged for this feature as part of #4223 )

PR acceptance criteria:

How to test changes / Special notes to the reviewer:

Prow should not fail overall execution. It should try executing the next target if existing one fails.

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation labels Dec 21, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Dec 21, 2020
@prietyc123 prietyc123 force-pushed the ExecuteWholeMakeTargetOnFailure branch 6 times, most recently from a2c4dfe to a4cda23 Compare December 22, 2020 10:40
@prietyc123 prietyc123 force-pushed the ExecuteWholeMakeTargetOnFailure branch from a4cda23 to 5dd4ada Compare December 22, 2020 10:42
@prietyc123
Copy link
Contributor Author

So we can see the PR behaves as expected https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_odo/4324/pull-ci-openshift-odo-master-v4.6-integration-e2e/1341333359082606592/artifacts/integration-e2e/integration-e2e-steps/container-logs/test.log . If any of the test fails jobs state shows failed, however it does not block the make target. The purpose of intentionally introduced failure has been achieved, so reverting the commit.

@prietyc123 prietyc123 changed the title [WIP] Execute make target consecutively even on failure Execute make target consecutively even on failure Dec 22, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Dec 22, 2020
@prietyc123 prietyc123 force-pushed the ExecuteWholeMakeTargetOnFailure branch from 91c4baf to 42f4571 Compare December 22, 2020 17:05
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: prietyc123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@prietyc123
Copy link
Contributor Author

Prow failure dur to #3256 .
Detailed log: https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_odo/4324/pull-ci-openshift-odo-master-v4.6-integration-e2e/1341429756121321472#1:build-log.txt%3A1272

/retest

@prietyc123
Copy link
Contributor Author

/retest

mohammedzee1000
mohammedzee1000 approved these changes Dec 24, 2020
View reviewed changes
Copy link
Contributor

@mohammedzee1000 mohammedzee1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Dec 24, 2020
@openshift-merge-robot openshift-merge-robot merged commit 96fc76e into redhat-developer:master Dec 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohammedzee1000 mohammedzee1000 mohammedzee1000 approved these changes

@rnapoles-rh rnapoles-rh Awaiting requested review from rnapoles-rh

Assignees

@mohammedzee1000 mohammedzee1000

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@prietyc123 @openshift-ci-robot @mohammedzee1000 @openshift-merge-robot