Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output service name when creating Operator backed service #4336

Merged
merged 2 commits into from
Jan 11, 2021
Merged

Conversation

dharmit
Copy link
Member

@dharmit dharmit commented Dec 31, 2020

What type of PR is this?
/kind bug

What does this PR do / why we need it:
It fixes a bug which leads to bad UX.

Which issue(s) this PR fixes:

Fixes #4013

PR acceptance criteria:

How to test changes / Special notes to the reviewer:
Create an Operator backed service without providing a name. You should now see the service name being used from the alm example:

$ odo service create etcdoperator.v0.9.4-clusterwide/EtcdCluster
Deploying service of type: EtcdCluster
 ✓  Deploying service [3ms]
 ✓  Service 'example' was created

Progress of the provisioning will not be reported and might take a long time
You can see the current status by executing 'odo service list'
Optionally, link etcdoperator.v0.9.4-clusterwide to your component by running: 'odo link <component-name>'

Earlier, we were seeing Service ' ' was created.

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Dec 31, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Dec 31, 2020
@dharmit
Copy link
Member Author

dharmit commented Jan 6, 2021

Failures seem unrelated to the PR:

 • Failure [244.365 seconds]
odo sub component command tests
/go/src/github.com/openshift/odo/tests/integration/cmd_cmp_sub_test.go:13
  Creating component using symlink
  /go/src/github.com/openshift/odo/tests/integration/component.go:694
    Should be able to deploy a spring boot uberjar file using symlinks in all odo commands [It]
    /go/src/github.com/openshift/odo/tests/integration/component.go:712
    No future change is possible.  Bailing out early after 240.941s.
      
    Running odo with args [odo component push --context /tmp/jhlemvwiph]
    Expected
        <int>: 1
    to match exit code:
        <int>: 0
    /go/src/github.com/openshift/odo/tests/helper/helper_run.go:34
------------------------------
• Failure [242.904 seconds]
odo sub component command tests
/go/src/github.com/openshift/odo/tests/integration/cmd_cmp_sub_test.go:13
  when component is in the current directory and --project flag is used
  /go/src/github.com/openshift/odo/tests/integration/component.go:493
    creates a local python component, pushes it and then deletes it using --all flag [It]
    /go/src/github.com/openshift/odo/tests/integration/component.go:521
    No future change is possible.  Bailing out early after 240.726s.
      
    Running odo with args [odo component push --context /tmp/573221927]
    Expected
        <int>: 1
    to match exit code:
        <int>: 0
    /go/src/github.com/openshift/odo/tests/helper/helper_run.go:34 

/retest

@mik-dass
Copy link
Contributor

mik-dass commented Jan 7, 2021

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dharmit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dharmit
Copy link
Member Author

dharmit commented Jan 7, 2021

Can we add a check here

https://github.com/openshift/odo/blob/e6be2586f5824bade91599f24686def26b53f1ee/tests/integration/operatorhub/cmd_service_test.go#L80

to verify that output contains the required name?

Makes sense. Added.

Copy link
Contributor

@mik-dass mik-dass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jan 11, 2021
@openshift-merge-robot openshift-merge-robot merged commit f463d09 into redhat-developer:master Jan 11, 2021
@dharmit dharmit deleted the fix-4013 branch January 12, 2021 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"odo service create" doesn't output service name when no parameters are provided
4 participants