Change default value for ephemral preference #4360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kadel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/test unit |
For not it assumes default value for ephemeral 'false'. It future releases we might change it 'true'. But for now we should play it safe and keep the old behaviour. We are not sure about all the consequences that this can have.
kadel
force-pushed
the
change-default-emphemeral-pref
branch
from
7c06bcf
to
b8c0bb8
Compare
|
@kadel Can we add doc for this as well? I'm asking because it would take the user to set |
unsetting ( I would be happy to add documentation, but where it should be? |
This doesn't work for me. 😞 Without setting any value for Ephemeral $ odo version
odo v2.0.3 (b8c0bb87d)
$ odo preference view
PARAMETER CURRENT_VALUE
UpdateNotification
NamePrefix
Timeout
BuildTimeout 3000
PushTimeout 480
Experimental
PushTarget
Ephemeral
$ odo create nodejs nodejs-ex
Validation
✓ Checking devfile existence [66493ns]
✓ Creating a devfile component from registry: DefaultDevfileRegistry [62813ns]
✓ Validating devfile component [252701ns]
Please use `odo push` command to create the component with source deployed
$ odo push
Validation
✓ Validating the devfile [38873ns]
Creating Kubernetes resources for component nodejs-ex
✓ Waiting for component to start [11s]
✓ Waiting for component to start [17ms]
Applying URL changes
✓ URL http-3000: http://http-3000-nodejs-ex-newproject.apps-crc.testing/ created
Syncing to component nodejs-ex
✓ Checking files for pushing [573362ns]
✓ Syncing files to the component [249ms]
Executing devfile commands for component nodejs-ex
✓ Waiting for component to start [2ms]
✓ Waiting for component to start [3ms]
✓ Waiting for component to start [3ms]
✓ Executing install command "npm install" [3s]
✓ Executing run command "npm start" [1s]
Pushing devfile component nodejs-ex
✓ Changes successfully pushed to component
$ kubectl get po,pvc
NAME READY STATUS RESTARTS AGE
pod/cockroach-operator-74bdfd6bf4-p7zjl 1/1 Running 0 3h19m
pod/nodejs-ex-74fd56cd8c-x2lvp 1/1 Running 0 38sExplicitly setting Ephemeral to false $ odo preference view
PARAMETER CURRENT_VALUE
UpdateNotification
NamePrefix
Timeout
BuildTimeout 3000
PushTimeout 480
Experimental
PushTarget
Ephemeral false
odo create nodejs nodejs-ex
Validation
✓ Checking devfile existence [34051ns]
✓ Creating a devfile component from registry: DefaultDevfileRegistry [43657ns]
✓ Validating devfile component [241173ns]
Please use `odo push` command to create the component with source deployed
$ odo push
Validation
✓ Validating the devfile [54278ns]
Creating Kubernetes resources for component nodejs-ex
✓ Waiting for component to start [10s]
✓ Waiting for component to start [15ms]
Applying URL changes
✓ URL http-3000: http://http-3000-nodejs-ex-newproject.apps-crc.testing/ created
Syncing to component nodejs-ex
✓ Checking files for pushing [557761ns]
✓ Syncing files to the component [275ms]
Executing devfile commands for component nodejs-ex
✓ Waiting for component to start [2ms]
✓ Waiting for component to start [2ms]
✓ Waiting for component to start [3ms]
✓ Executing install command "npm install" [4s]
✓ Executing run command "npm start" [1s]
Pushing devfile component nodejs-ex
✓ Changes successfully pushed to component
$ kubectl get po,pvc
NAME READY STATUS RESTARTS AGE
pod/cockroach-operator-74bdfd6bf4-p7zjl 1/1 Running 0 3h19m
pod/nodejs-ex-6bf76f657d-2gxb6 1/1 Running 0 17s
NAME STATUS VOLUME CAPACITY ACCESS MODES STORAGECLASS AGE
persistentvolumeclaim/odo-projects-nodejs-ex-tzos Bound pv0016 100Gi RWO,ROX,RWX 17s |
|
That is weird. There is a test to test the default value https://github.com/openshift/odo/pull/4360/files#diff-a22366462d78266515a5177dc92bc1ef5901a1b05d9de4f7825a5a74d6f63a52R274-R292 |
Not sure why, but it works for me now. 🤷♂️ |
openshift-ci-robot
added
the
lgtm
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does does this PR do / why we need it:
For now, it assumes default value for ephemeral 'false'.
In future releases, we might change it 'true'. But for now, we should
play it safe and keep the old behavior. We are not sure about all the
consequences that this can have.
Which issue(s) this PR fixes:
Fixes #?
PR acceptance criteria:
Unit test
Integration test
Documentation
I have read the test guidelines
How to test changes / Special notes to the reviewer: