Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactors url List() to use URL Client #4366

Merged
merged 3 commits into from
Feb 3, 2021
Merged

Refactors url List() to use URL Client #4366

merged 3 commits into from
Feb 3, 2021

Conversation

mik-dass
Copy link
Contributor

@mik-dass mik-dass commented Jan 15, 2021 •
edited
Loading

What type of PR is this?

/kind code-refactoring

What does does this PR do / why we need it:

Refactors url List() to use URL Client. It also adds ListCluster() to get urls from the cluster.

Which issue(s) this PR fixes:

Fixes part of #4298

PR acceptance criteria:

How to test changes / Special notes to the reviewer:

  • Tests should pass.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Jan 15, 2021
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Jan 15, 2021
@mik-dass mik-dass force-pushed the url_list_refactor branch 2 times, most recently from d3124f4 to 9f1e335 Compare January 19, 2021 13:55
@mik-dass mik-dass changed the title [WIP] Refactors url List() to use URL Client Refactors url List() to use URL Client Jan 19, 2021
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Jan 19, 2021
@mik-dass mik-dass force-pushed the url_list_refactor branch 3 times, most recently from cb231a9 to 83e5d01 Compare January 19, 2021 14:21
dharmit
dharmit suggested changes Jan 21, 2021
View reviewed changes
pkg/component/component.go Outdated Show resolved Hide resolved
pkg/devfile/adapters/docker/component/utils_test.go Outdated Show resolved Hide resolved
pkg/odo/cli/component/status.go Outdated Show resolved Hide resolved
pkg/url/kubernetes.go Show resolved Hide resolved
pkg/url/kubernetes.go Outdated Show resolved Hide resolved
pkg/url/kubernetes.go Show resolved Hide resolved
dharmit
dharmit approved these changes Jan 28, 2021
View reviewed changes
Copy link
Member

@dharmit dharmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@mik-dass thanks for addressing the requests. 🙇‍♂️ 👍

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jan 28, 2021
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dharmit, mik-dass

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@mik-dass
Copy link
Contributor Author 

Should be able to verify the nodejs-12-rhel7 image [It]
    /go/src/github.com/openshift/odo/tests/e2escenarios/e2e_images_test.go:137
    Failed after 90 retries. Content in  doesn't include 'Hello'.

/hold

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. and removed lgtm Indicates that a PR is ready to be merged. Required by Prow. labels Jan 28, 2021
@mik-dass
Copy link
Contributor Author 

error: build error: error creating build container: Error initializing source docker://registry.svc.ci.openshift.org/openshift/release:golang-1.13: Get "https://registry.svc.ci.openshift.org/openshift/token?account=serviceaccount&scope=repository%3Aopenshift%2Frelease%3Apull": dial tcp 35.196.103.194:443: connect: no route to host

/retest

@mik-dass
Copy link
Contributor Author 

th args [oc exec eqnbje-97cd44cfd-4ncgk -c runtime --namespace anwidomgtr -- ps -ef]
[oc] Signal 23 (URG) caught by ps (3.3.15).
[oc] ps:ps/display.c:66: please report this bug
[oc] command terminated with exit code 1
Deleting project: anwidomgtr

/retest

@dharmit
Copy link
Member

dharmit commented Feb 3, 2021 •
edited
Loading

@mik-dass can you address the conflicts? I'd try to get this in before the end of this Sprint. Also, please remove the hold if things are good.

@mik-dass
Refactors url List() to use URL Client.
e0f779e 
It also adds ListCluster() to get urls from the cluster.

Signed-off-by: mik-dass <mrinald7@gmail.com>
@mik-dass
Adds comments and fixes variable names
af19576
@mik-dass
Fixes occlient error while creating new URL client
0f16b05
@mik-dass
Copy link
Contributor Author

mik-dass commented Feb 3, 2021

@mik-dass can you address the conflicts? I'd try to get this in before the end of this Sprint. Also, please remove the hold if things are good.

Fixed

@mik-dass mik-dass removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. label Feb 3, 2021
dharmit
dharmit approved these changes Feb 3, 2021
View reviewed changes
Copy link
Member

@dharmit dharmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Feb 3, 2021
@openshift-merge-robot openshift-merge-robot merged commit a4b40a9 into redhat-developer:master Feb 3, 2021
@mik-dass mik-dass deleted the url_list_refactor branch February 3, 2021 14:53
kadel pushed a commit to kadel/odo that referenced this pull request Feb 4, 2021
@mik-dass @kadel
Refactors url List() to use URL Client (redhat-developer#4366)
f3d4cff 
* Refactors url List() to use URL Client.

It also adds ListCluster() to get urls from the cluster.

Signed-off-by: mik-dass <mrinald7@gmail.com>

* Adds comments and fixes variable names

* Fixes occlient error while creating new URL client
@rm3l rm3l added the area/refactoring Issues or PRs related to code refactoring label Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dharmit dharmit dharmit approved these changes

@girishramnani girishramnani Awaiting requested review from girishramnani

@mohammedzee1000 mohammedzee1000 Awaiting requested review from mohammedzee1000

Assignees

@dharmit dharmit

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. area/refactoring Issues or PRs related to code refactoring lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mik-dass @openshift-ci-robot @openshift-bot @dharmit @rm3l @openshift-merge-robot