Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes catalog list services for minishift #4377

Merged
merged 2 commits into from
Jan 23, 2021
Merged

Fixes catalog list services for minishift #4377

merged 2 commits into from
Jan 23, 2021

Conversation

dharmit
Copy link
Member

@dharmit dharmit commented Jan 21, 2021

What type of PR is this?
/kind bug

What does this PR do / why we need it:
$subject

Which issue(s) this PR fixes:

Fixes #4376

PR acceptance criteria:

How to test changes / Special notes to the reviewer:
odo catalog list services should pass on all the three platforms:

  • Kubernetes (minikube)
  • OCP 4.x (CRC)
  • OCP 3.11 (minishift)

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jan 21, 2021
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dharmit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Jan 21, 2021
@dharmit
Move CSV support check to business logic
94c73a4 
This is done to satisfy the "gosimple" lint. Check
#4377 (comment) for
more info.
@dharmit
Copy link
Member Author

dharmit commented Jan 21, 2021

Unit test failure:

golangci-lint run ./... --timeout 5m
pkg/odo/cli/catalog/list/services.go:44:58: S1002: should omit comparison to bool constant, can be simplified to `!csvSupport` (gosimple)
		} else if csvSupport, _ := o.KClient.IsCSVSupported(); csvSupport == false {

@prietyc123 prietyc123 mentioned this pull request Jan 22, 2021
Merged
@girishramnani
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jan 22, 2021
@dharmit
Copy link
Member Author

dharmit commented Jan 22, 2021

/test v4.6-integration-e2e

@anandrkskd
Copy link
Contributor

I have tested PR on openshift 3.11(minishift) and it's passing successfully.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

10 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 3d70bc6 into redhat-developer:master Jan 23, 2021
@dharmit dharmit deleted the fix-4376 branch January 27, 2021 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohammedzee1000 mohammedzee1000 Awaiting requested review from mohammedzee1000

@prietyc123 prietyc123 Awaiting requested review from prietyc123

Assignees

@girishramnani girishramnani

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"odo catalog list services" fails on minishift
6 participants
@dharmit @openshift-ci-robot @girishramnani @anandrkskd @openshift-bot @openshift-merge-robot