Adds debug-command flag to odo watch

[mik-dass]

What type of PR is this?

/kind feature

What does does this PR do / why we need it:

It takes the custom debug command from the CLI while trigerring odo watch.

Which issue(s) this PR fixes:

Fixes #4357

PR acceptance criteria:

• Unit test

• Integration test

• Documentation

• I have read the test guidelines

How to test changes / Special notes to the reviewer:

• odo watch --debug-command <custom debug command> should work.

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mik-dass

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mik-dass]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dharmit]

@mik-dass can you please add docs about how to use this so that we can update odo.dev website as well?

[mik-dass]

@mik-dass can you please add docs about how to use this so that we can update odo.dev website as well?

I have added a mention of the watch flags in a doc.

[dharmit]

$ odo create nodejs --starter
$ odo push --debug
...
...

$ odo watch --debug-command npm run debug
Error: unknown command "run" for "odo watch"
Usage:
  odo watch [flags]
...
...

Am I doing something wrong here? The debug command that I have used here npm run debug was available from https://odo.dev/docs/debugging-using-devfile/.

Tangential note: it would help to have more documentation about odo watch on odo.dev. Or maybe it's just me struggling to find examples to test functionality when a PR related to odo watch pops up. 😞

[mik-dass]

Am I doing something wrong here? The debug command that I have used here npm run debug was available from https://odo.dev/docs/debugging-using-devfile/.

You need to mention the id of the devfile command not the command itself.

odo watch --debug-command debug

[dharmit]

Am I doing something wrong here? The debug command that I have used here npm run debug was available from https://odo.dev/docs/debugging-using-devfile/.

You need to mention the id of the devfile command not the command itself.

odo watch --debug-command debug

🤦‍♂️

@mik-dass I am LGTM'ing this but, is it possible for you to review the docs for debug support on odo.dev and add something if needed? I personally feel that what you've added to docs in this PR can also be added to Debugging using devfile. Maybe we can ask @kadel to look at these from new user's perspective like he did for odo service and odo link.

/lgtm

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[mik-dass]

@mik-dass I am LGTM'ing this but, is it possible for you to review the docs for debug support on odo.dev and add something if needed?

OK I will try to review the docs for proper debug support.