Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added java-maven to the list of components to be tested #4427

Merged
merged 1 commit into from
Feb 11, 2021
Merged

Added java-maven to the list of components to be tested #4427

merged 1 commit into from
Feb 11, 2021

Conversation

rnapoles-rh
Copy link
Contributor

What type of PR is this?
/kind feature

What does does this PR do / why we need it:
Adding java-maven to be tested in the devfile debug e2e scenarios

Which issue(s) this PR fixes:

Fixes #4162

PR acceptance criteria:

How to test changes / Special notes to the reviewer:
make test-e2e-devfile

@openshift-ci-robot openshift-ci-robot added the kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation label Feb 10, 2021
@rnapoles-rh
Copy link
Contributor Author

devfile debug for nodejs failed for this PR, however in PR4406 test for java-openliberty failed and nodejs passed. Retesting.

@rnapoles-rh
Copy link
Contributor Author

/retest

@dharmit
Copy link
Member

dharmit commented Feb 11, 2021 

I0211 04:16:39.847647  978229 events.go:52] Warning Event: Count: 7, Reason: Failed, Message: Error: secret "hzhglm-etcdcluster-example" not found
[ssh:Fedora 32] [odo]  ✗  Waiting for component to start [5m] [WARNING x7: Failed]
[ssh:Fedora 32] [odo]  ✗  Failed to start component with name hzhglm. Error: Failed to create the component: error while waiting for deployment rollout: timeout while waiting for hzhglm deployment roll out\nFor more information to help determine the cause of the error, re-run with '-v'.
[ssh:Fedora 32] [odo] See below for a list of failed events that occured more than 5 times during deployment:
[ssh:Fedora 32] [odo] 
[ssh:Fedora 32] [odo]  NAME                                      COUNT  REASON  MESSAGE                        
[ssh:Fedora 32] [odo] 
[ssh:Fedora 32] [odo]  hzhglm-788f84d788-ggpwb.16629655170957fd  7      Failed  Error: secret                  
[ssh:Fedora 32] [odo]                                                           "hzhglm-etcdcluster-example"   
[ssh:Fedora 32] [odo]                                                           not found                      
[ssh:Fedora 32] [odo] 
[ssh:Fedora 32] [odo] 
[ssh:Fedora 32] Deleting project: denjxzfvkn
[ssh:Fedora 32] Running odo with args [odo project delete denjxzfvkn -f]

#4301
/retest

dharmit
dharmit approved these changes Feb 11, 2021
View reviewed changes
Copy link
Member

@dharmit dharmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

(small change.)

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Feb 11, 2021
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dharmit, rnapoles-rh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Feb 11, 2021
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 8c96ec8 into redhat-developer:master Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dharmit dharmit dharmit approved these changes

@mohammedzee1000 mohammedzee1000 Awaiting requested review from mohammedzee1000

@prietyc123 prietyc123 Awaiting requested review from prietyc123

Assignees

@dharmit dharmit

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add e2e scenario for java-maven devfile debug command
5 participants
@rnapoles-rh @dharmit @openshift-ci-robot @openshift-bot @openshift-merge-robot