[bz1501271] Attempt to use ami ssh user and default to ansible_ssh_user. #5794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XS
|
/lgtm |
|
/kind bug |
openshift-ci-robot
added
kind/bug
michaelgugino
approved these changes
Oct 18, 2017
|
/test all |
|
These failures having nothing to do with this change. This change is for building AMIs which currently is not part of the CI jobs. /test install upgrade |
|
@sdodson, please review this as well. |
|
/retest |
|
flake on openshift/origin#16929 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for https://bugzilla.redhat.com/show_bug.cgi?id=1501271 that defaults the user to root. This now attempts to use
openshift_aws_build_ami_ssh_userand defaults toansible_ssh_user.