Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1684643, applied QE feedback to Performance and Scalability content #13970

Merged
merged 1 commit into from
Mar 20, 2019

Conversation

@ahardin-rh ahardin-rh added this to the Future Release milestone Mar 4, 2019
@ahardin-rh ahardin-rh self-assigned this Mar 4, 2019
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 4, 2019
@ahardin-rh
Copy link
Contributor Author

@mffiedler @wabouhamad I started to address some of the review feedback . There are still some open questions on how to handle some issues, but can you please take a look at what is in place and let me know if I missed anything? Thanks!

@openshift-docs-preview-bot

The preview will be availble shortly at:

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 13, 2019
@mffiedler
Copy link

@hongkailiu Please help review as well. Preview link: https://scale-BZ-4-0--ocpdocs.netlify.com/

@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 13, 2019
@hongkailiu
Copy link
Member

@hongkailiu Please help review as well. Preview link: https://scale-BZ-4-0--ocpdocs.netlify.com/

Will do tomorrow.

@ahardin-rh
Copy link
Contributor Author

@hongkailiu You mentioned on today's call that there are outstanding issues on this work, but I am not sure what you mean. Can you please let me know what I missed? Thanks!

@hongkailiu
Copy link
Member

@hongkailiu You mentioned on today's call that there are outstanding issues on this work, but I am not sure what you mean. Can you please let me know what I missed? Thanks!

Oh. I meant that there are still open issues in the gdoc.
I feel it would be easier to start the review as a whole when all issues get addressed.

@hongkailiu
Copy link
Member

hongkailiu commented Mar 19, 2019

Remark 3,8,9 are still open. Otherwise lgtm.

@ahardin-rh
Copy link
Contributor Author

@akrzos Can you please help me confirm that the content on this page is still relevant for the 4.0/4.1 release? If not, I can remove that page.
http://file.rdu.redhat.com/~ahardin/03052019/scale-BZ-4-0/scalability_and_performance/optimizing-compute-resources.html

The review feedback says:

Not sure if this page still applies to OCP 4.0 since RHCOS is the OS on the node. Maybe for bring your own host in the future?

Once we have this confirmed, I think we can merge these changes. We'll open new PRs to address the other 2 open issues noted by Hongkai. Ravi and Sebastian are working on those pieces, but that work should not block these fixes.

@akrzos
Copy link

akrzos commented Mar 20, 2019

@akrzos Can you please help me confirm that the content on this page is still relevant for the 4.0/4.1 release? If not, I can remove that page.
http://file.rdu.redhat.com/~ahardin/03052019/scale-BZ-4-0/scalability_and_performance/optimizing-compute-resources.html

Everything looks relevant to me. I can run and see the rhel-tools containers by using the oc debug node/<node> cli referenced and debug/see things on the host from the container.

The review feedback says:

Not sure if this page still applies to OCP 4.0 since RHCOS is the OS on the node. Maybe for bring your own host in the future?

Once we have this confirmed, I think we can merge these changes. We'll open new PRs to address the other 2 open issues noted by Hongkai. Ravi and Sebastian are working on those pieces, but that work should not block these fixes.

@ahardin-rh
Copy link
Contributor Author

@akrzos Thanks for confirming! I will merge these changes and will follow up with Ravi and Sebastian on the other 2 forthcoming items in separate PRs.

@ahardin-rh ahardin-rh merged commit 2a02f61 into openshift:enterprise-4.0 Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.1 size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants