-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BZ1920404: Create migration controller in MTC upgrade #28837
Conversation
The preview will be available shortly at: |
|
||
ifeval::["{mtc-version}" > "1.3"] | ||
You can upgrade the {mtc-full} ({mtc-short}) Operator on an {product-title} 4 cluster with the Operator Lifecycle Manager. | ||
You can upgrade the {mtc-full} ({mtc-short}) on an {product-title} 4 cluster by using the Operator Lifecycle Manager (OLM) to install the {mtc-full} Operator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@apinnick do we need to clarify the upgrade is from MTC 1.3.x -> 1.4.0? If customer is using 1.2.5, the upgrade guide is not the same.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understood that we are not supporting 1.2 upgrade. Who can clarify this?
It seem the description overlap |
They do overlap. If someone is upgrading MTC on a 4.x source cluster and a 4.x target cluster, they have to verify that the right pods are running on both clusters. I'll try to find a better way to phrase this. |
Why did we add changes related to Automatic operator upgrades for 3 to 4 (https://docs.openshift.com/container-platform/4.6/migration/migrating_3_4/upgrading-migration-tool-3-4.html#migration-upgrading-migration-tool-4_migrating-3-4 does not have anything related to this). I'm concerned about Automatic operator upgrades because if your ocp4 MTC automatically upgrades, you aren't likely to notice that happen or it could happen mid-migration, which is likely going to break you because it must be on the same version as your source, and 3.x does not automatically update. It requires manual intervention to keep these in sync. |
Correct. The Operator on the OCP4 cluster should not update automatically or else the versions will not be in sync. The Operator auto upgrades were part of the single module for upgrading MTC on OCP4 cluster, regardless of the environment. I can add conditions so that auto upgrade is not mentioned in the 3-to-4 migration docs. Maybe I should add an explicit note not to enable subscriptions. I think updates are enabled by default. Will check. |
AH okay, thank you that explains it. We need to be careful to avoid recommending auto upgrades for the target on ocp3 -> ocp4, it's probably acceptable and even desired on ocp4 -> ocp4 scenarios where both clusters will update. Maybe it makes sense to explain the issue for ocp3 -> ocp4 case and strongly recommend manual upgrades? |
fd3002b
to
5ae4053
Compare
LGTM |
5ae4053
to
77eccf7
Compare
Deploy preview for osdocs ready! Built with commit c92603b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor nits and suggestions and otherwise LGTM!
7073dc2
to
4f11920
Compare
4f11920
to
c92603b
Compare
/cherrypick enterprise-4.7 |
@apinnick: new pull request created: #28986 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick enterprise-4.6 |
@apinnick: new pull request created: #28987 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick enterprise-4.5 |
@apinnick: new pull request created: #28988 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
https://bugzilla.redhat.com/show_bug.cgi?id=1920404
For MTC 1.4.0 (Feb 10)
CP to 4.5, 4.6, 4.7
Preview sections:
https://bz1920404_upgrade-mtc--ocpdocs.netlify.app/openshift-enterprise/latest/migration/migrating_3_4/upgrading-migration-tool-3-4.html
https://bz1920404_upgrade-mtc--ocpdocs.netlify.app/openshift-enterprise/latest/migration/migrating_4_1_4/upgrading-migration-tool-4-1-4.html
https://bz1920404_upgrade-mtc--ocpdocs.netlify.app/openshift-enterprise/latest/migration/migrating_4_2_4/upgrading-migration-tool-4-2-4.html