Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BZ1920404: Create migration controller in MTC upgrade #28837

Merged
merged 1 commit into from
Jan 31, 2021

Conversation

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 26, 2021
@openshift-docs-preview-bot

The preview will be available shortly at:


ifeval::["{mtc-version}" > "1.3"]
You can upgrade the {mtc-full} ({mtc-short}) Operator on an {product-title} 4 cluster with the Operator Lifecycle Manager.
You can upgrade the {mtc-full} ({mtc-short}) on an {product-title} 4 cluster by using the Operator Lifecycle Manager (OLM) to install the {mtc-full} Operator.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@apinnick do we need to clarify the upgrade is from MTC 1.3.x -> 1.4.0? If customer is using 1.2.5, the upgrade guide is not the same.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understood that we are not supporting 1.2 upgrade. Who can clarify this?

@xinredhat
Copy link

https://bz1920404_upgrade-mtc--ocpdocs.netlify.app/openshift-enterprise/latest/migration/migrating_4_2_4/upgrading-migration-tool-4-2-4.html

9.Click Workloads → Pods to verify that the ControllerManager, MigrationUI, Restic, and Velero pods are running on the target cluster.
10. Click Workloads → Pods to verify that the Restic, and Velero pods are running if you are upgrading MTC on the source cluster.

It seem the description overlap

@apinnick
Copy link
Contributor Author

https://bz1920404_upgrade-mtc--ocpdocs.netlify.app/openshift-enterprise/latest/migration/migrating_4_2_4/upgrading-migration-tool-4-2-4.html

9.Click Workloads → Pods to verify that the ControllerManager, MigrationUI, Restic, and Velero pods are running on the target cluster.
10. Click Workloads → Pods to verify that the Restic, and Velero pods are running if you are upgrading MTC on the source cluster.

It seem the description overlap

They do overlap. If someone is upgrading MTC on a 4.x source cluster and a 4.x target cluster, they have to verify that the right pods are running on both clusters. I'll try to find a better way to phrase this.

@eriknelson
Copy link

Why did we add changes related to Automatic operator upgrades for 3 to 4 (https://docs.openshift.com/container-platform/4.6/migration/migrating_3_4/upgrading-migration-tool-3-4.html#migration-upgrading-migration-tool-4_migrating-3-4 does not have anything related to this).

I'm concerned about Automatic operator upgrades because if your ocp4 MTC automatically upgrades, you aren't likely to notice that happen or it could happen mid-migration, which is likely going to break you because it must be on the same version as your source, and 3.x does not automatically update. It requires manual intervention to keep these in sync.

@apinnick
Copy link
Contributor Author

Why did we add changes related to Automatic operator upgrades for 3 to 4 (https://docs.openshift.com/container-platform/4.6/migration/migrating_3_4/upgrading-migration-tool-3-4.html#migration-upgrading-migration-tool-4_migrating-3-4 does not have anything related to this).

I'm concerned about Automatic operator upgrades because if your ocp4 MTC automatically upgrades, you aren't likely to notice that happen or it could happen mid-migration, which is likely going to break you because it must be on the same version as your source, and 3.x does not automatically update. It requires manual intervention to keep these in sync.

Correct. The Operator on the OCP4 cluster should not update automatically or else the versions will not be in sync.

The Operator auto upgrades were part of the single module for upgrading MTC on OCP4 cluster, regardless of the environment. I can add conditions so that auto upgrade is not mentioned in the 3-to-4 migration docs. Maybe I should add an explicit note not to enable subscriptions. I think updates are enabled by default. Will check.

@eriknelson
Copy link

Why did we add changes related to Automatic operator upgrades for 3 to 4 (https://docs.openshift.com/container-platform/4.6/migration/migrating_3_4/upgrading-migration-tool-3-4.html#migration-upgrading-migration-tool-4_migrating-3-4 does not have anything related to this).
I'm concerned about Automatic operator upgrades because if your ocp4 MTC automatically upgrades, you aren't likely to notice that happen or it could happen mid-migration, which is likely going to break you because it must be on the same version as your source, and 3.x does not automatically update. It requires manual intervention to keep these in sync.

Correct. The Operator on the OCP4 cluster should not update automatically or else the versions will not be in sync.

The Operator auto upgrades were part of the single module for upgrading MTC on OCP4 cluster, regardless of the environment.

AH okay, thank you that explains it. We need to be careful to avoid recommending auto upgrades for the target on ocp3 -> ocp4, it's probably acceptable and even desired on ocp4 -> ocp4 scenarios where both clusters will update.

Maybe it makes sense to explain the issue for ocp3 -> ocp4 case and strongly recommend manual upgrades?

@apinnick apinnick force-pushed the BZ1920404_upgrade-mtc branch 5 times, most recently from fd3002b to 5ae4053 Compare January 27, 2021 10:28
@xinredhat
Copy link

LGTM

@apinnick apinnick marked this pull request as ready for review January 28, 2021 07:39
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 28, 2021
@apinnick apinnick force-pushed the BZ1920404_upgrade-mtc branch from 5ae4053 to 77eccf7 Compare January 28, 2021 11:34
@netlify
Copy link

netlify bot commented Jan 28, 2021

Deploy preview for osdocs ready!

Built with commit c92603b

https://deploy-preview-28837--osdocs.netlify.app

Copy link
Contributor

@bobfuru bobfuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor nits and suggestions and otherwise LGTM!

@bobfuru bobfuru added the peer-review-done Signifies that the peer review team has reviewed this PR label Jan 28, 2021
@apinnick apinnick force-pushed the BZ1920404_upgrade-mtc branch 2 times, most recently from 7073dc2 to 4f11920 Compare January 31, 2021 09:42
@apinnick apinnick force-pushed the BZ1920404_upgrade-mtc branch from 4f11920 to c92603b Compare January 31, 2021 09:45
@apinnick apinnick merged commit 7e315a0 into openshift:master Jan 31, 2021
@apinnick
Copy link
Contributor Author

apinnick commented Jan 31, 2021

/cherrypick enterprise-4.7

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jan 31, 2021

@apinnick: new pull request created: #28986

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@apinnick
Copy link
Contributor Author

apinnick commented Jan 31, 2021

/cherrypick enterprise-4.6

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jan 31, 2021

@apinnick: new pull request created: #28987

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@apinnick
Copy link
Contributor Author

apinnick commented Jan 31, 2021

/cherrypick enterprise-4.5

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jan 31, 2021

@apinnick: new pull request created: #28988

In response to this:

/cherrypick enterprise-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.5 branch/enterprise-4.6 branch/enterprise-4.7 peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants