Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHACS] Updated steps for MITRE ATT&CK #36201

Merged
merged 1 commit into from
Oct 6, 2021
Merged

[RHACS] Updated steps for MITRE ATT&CK #36201

merged 1 commit into from
Oct 6, 2021

Conversation

gaurav-nelson
Copy link
Contributor

@gaurav-nelson gaurav-nelson commented Sep 9, 2021

  • Added instructions for specifying MITRE ATT&CK tactics and techniques
  • nit fix

NOTES:

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 9, 2021
@sagidlow
Copy link
Contributor

sagidlow commented Sep 9, 2021

LGTM!

@IAmATeaPot418
Copy link

Very minor and not sure if its worth addressing at all to be honest but the workflow is "add tactic"

image

Select a tactic:

image

Click Plus Box

image

Select Technique

image

If we want to go through explicitly on the process then I think this needs to be changed. If thats not the intent then I think its fine as is.

@gaurav-nelson
Copy link
Contributor Author

@sagidlow I've updated the PR to include the information based on the SME input, can you please review and merge?

Copy link
Contributor

@ctauchen ctauchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good -- I've left a few suggestions for you to consider.

First, a bit of housekeeping:

Does this have an associated JIRA or BZ? If so, can you update the title to include this (ex. JIRA/BZ-NNNN: bla bla bla)?

modules/create-policy-from-system-policies-view.adoc Outdated Show resolved Hide resolved
modules/create-policy-from-system-policies-view.adoc Outdated Show resolved Hide resolved
@ctauchen
Copy link
Contributor

@bergerhoffer @bobfuru FYI

@bobfuru bobfuru added the peer-review-done Signifies that the peer review team has reviewed this PR label Sep 29, 2021
@bobfuru
Copy link
Contributor

bobfuru commented Sep 29, 2021

Let me know when you've applied any feedback and this is ready for merge, @gaurav-nelson.

@gaurav-nelson
Copy link
Contributor Author

gaurav-nelson commented Sep 30, 2021

@bobfuru This is good to merge.

Thank you @ctauchen , we are still establishing process for issues and other bits, so right now we don't have any labels or links for the issues.

@mikemckiernan mikemckiernan merged commit 2765acf into openshift:rhacs-docs Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants