-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH#35793 Update minimum storage requirements for all providers from 120GB -> 100GB #36226
Conversation
✔️ Deploy Preview for osdocs ready! 🔨 Explore the source changes: 6cf94d3 🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/6144c82a46f8e500074e4d34 😎 Browse the preview: https://deploy-preview-36226--osdocs.netlify.app |
512ea90
to
f1d65bb
Compare
@miabbott can you verify? Thanks! |
LGTM |
Due to our docs support policy, this will require several ACKs from stakeholders before merging. @nstielau @xltian @sferich888 @makentenza @vikram-redhat can you ACK this documentation update for minimum storage requirements for a cluster VM? Thanks! |
LGTM |
ACK (and ill proxy @nstielau via #35793 (comment) and #35793 (comment)) |
LGTM, thanks! |
one comment from Z and LinuxONE side. The documentation above considers the off-prem side of things for KVM. We should change the minimum for all Z related docs including z/VM as well. I appreciate the lower minimum. |
I've verified 100 GB also show in the z/VM on IBM Z and LinuxONE machine requirements now. |
LGTM |
I think we should not have a statement about IOPS for z and LinuxONE since this is not commonly used by our customers. |
@nstielau wanted to check with you on this recommendation. Are you OK with hiding the IOPS column for IBM Z and LinuxONE? |
Is there any technical reason why a Z or LinuxONE customer should have any issues to satisfy the required IOPS? From my point of view not having a high demand on these platforms is not a reason to avoid these requirements. |
My 2 cents: 100GB is more than sufficient for a bare minimum installation, some examples:
However, please note that IOPS could be critical for ETCD performance and cluster stability, I remember cases in the past where the default type of disks being used had very poor performance (e.g. Azure). Additional references: Best Regards. |
There is not a issue to satisfy those requirements - all testing do show no problems on the setup. I do agree that IO bandwidth needs to be available and the setup needs to be done that the required demand is satisfied. We verify before each release that all requirements are satisfied and would document anything the customer needs to perform to get the correct setup done. The IOPS metric is just not really used on Z and LinuxONE and if we introduce this to the documentation we would need to tell the customer how they can find out how to verify what IOPS they have. This would mean service questions. Therefore we would need a whole chapter to tell the customer how he can get this verified. Therefore I suggest keep the model as we have it right now and do not introduce this part of the table for Z and LinuxONE. |
@codyhoag confirmed on AWS platform, LGTM. |
I verified 100G on vSphere platform, it works well. |
@codyhoag can we use this PR to reflect this change as well on the provided templates for UPI deployments? At least for AWS we provide 120 fixed sizes (https://docs.openshift.com/container-platform/4.8/installing/installing_aws/installing-aws-user-infra.html#installation-cloudformation-control-plane_installing-aws-user-infra |
Because the UPI templates are auto-generated from the openshift/installer repo, once the templates are updated there by Engineering, the changes will be reflected in the docs 👍 |
@jianlinliu Can you check if we complete all the verification? |
Thanks for @pamoedom mentioned IOPS, especially for azure platform, that is really a good point. I totally agree with that. cc @mgahagan73 and @Amoghrd to notice this. After go through the PR, sound like the minimum requirement does not link to azure install, so I think this PR is safe to merge. |
@jianlinliu is Azure the only provider you have concerns for these adjustments applying to? We have a follow-up planned to add this table to providers that don't have it (AWS, Azure, GCP). So we'd like to confirm this information is applicable everywhere (or gather what needs to be adjusted per provider). |
@codyhoag for gcp/aws/azure, as far as I know, installer do some minimum requirement check when running installation, especially for control-plane, I guess the minimum requirement on those cloud platforms should be aligned with the ones installer required. |
Let's replace the Z IOPS requirement with "N/A". Of course disk performance is still a consideration, but if "iops |
f1d65bb
to
f397513
Compare
Thanks, all! I have made the recommended changes. We have all the necessary ACKs to get this merged. I'll wait until EOD tomorrow (EST) and proceed with merging if there are no other comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like it's all rendering right. :) I have a style pick, then it's good to go.
f397513
to
6cf94d3
Compare
/cherrypick enterprise-4.9 |
/cherrypick enterprise-4.8 |
/cherrypick enterprise-4.7 |
/cherrypick enterprise-4.6 |
@codyhoag: new pull request created: #36523 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@codyhoag: #36226 failed to apply on top of branch "enterprise-4.8":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@codyhoag: #36226 failed to apply on top of branch "enterprise-4.7":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@codyhoag: #36226 failed to apply on top of branch "enterprise-4.6":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Resolves #35793
Updates were made in the machine requirement section for all providers that specified that table. For example: