-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JIRA-OSDOCS3322: Updated the steps for cluster upgrades per the UI changes #44907
Conversation
✅ Deploy Preview for osdocs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
3ec85aa
to
7c00561
Compare
c587557
to
6778d1c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added additional context that admin requirement is only for y-stream versions, while the z-stream versions continue to happen automatically
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed the ROSA pages.
@@ -105,6 +105,11 @@ If the cluster privacy is set to *Private*, you cannot access your cluster until | |||
You can review the end-of-life dates in the update life cycle documentation for {product-title}. For more information, see _{product-title} update life cycle_. | |||
==== | |||
+ | |||
.. Provide administrator approval per your cluster update method: | |||
** Individual updates: If you select an update version that requires approval, provide an administrator’s acknowledgment and click *Approve and continue*. | |||
** Recurring updates: If you selected recurring updates for your cluster, provide an administrator’s acknowledgment and click *Approve and continue*. The {cluster-manager} does not start scheduled updates without receiving an administrator's acknowledgment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
y-stream upgrade is controlled by another attribute enable_minor_version_upgrades set to true which is not supported on UI yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested small text corrections.
New changes are detected. LGTM label has been removed. |
@wgordon17 , @xueli181114 : I incorporated your feedback. Could you please review the doc updates and let me know if you have any additional comments? Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise, LGTM!
@@ -28,7 +28,11 @@ endif::sts[] | |||
. Log in to {cluster-manager-url}. | |||
. Select a cluster to upgrade. | |||
. Click the *Settings* tab. | |||
. In the *Update strategy* pane, click *Manual* or *Individual Updates*. | |||
. In the *Update strategy* pane, select *Individual Updates*. | |||
. Select the version you want to upgrade your cluster to. Recommended cluster upgrades are notated in the UI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recommend changing to "Recommended cluster upgrades appear in the UI." for simpler language.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made the change.
modules/upgrade-manual.adoc
Outdated
. Click *Update* in the *Update Status* box. | ||
|
||
. Select the version you want to upgrade your cluster to. Recommended cluster upgrades will be notated in the UI. To learn more about each available upgrade version, click *View release notes*. | ||
. Select the version you want to upgrade your cluster to. Recommended cluster upgrades are notated in the UI. To learn more about each available upgrade version, click *View release notes*. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incorporated the feedback.
modules/upgrade.adoc
Outdated
|
||
If you opt for manual upgrades, you are responsible for updating your cluster. If your cluster version falls too far behind, it will transition to a limited support status. For more information on OpenShift life cycle policies, see xref:../osd_policy/osd-life-cycle.adoc#osd-life-cycle[{product-title} update life cycle]. | ||
If you opt for manual upgrades, you are responsible for updating your cluster. If your cluster version falls too far behind, it will transition to a limited support status. For more information on OpenShift life cycle policies, see xref:../osd_architecture/osd_policy/osd-life-cycle.adoc#osd-life-cycle[{product-title} update life cycle]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change "fall too far behind" to "becomes outdated"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made the change.
16e4d60
to
031adb3
Compare
031adb3
to
5bd779b
Compare
and incorporated tech. and peer feedback
5bd779b
to
60a20ca
Compare
/cherry-pick enterprise-4.10 |
/cherry-pick enterprise-4.11 |
@maxwelldb: new pull request created: #46906 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@maxwelldb: new pull request created: #46907 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR is to address the JIRA issue: https://issues.redhat.com/browse/OSDOCS-3322
Following is the change:
Per the latest UI changes, made the following updates to the cluster upgrade content:
Wireframe: https://marvelapp.com/prototype/hdh8ai1/screen/84703875
The change is seen in the following topics:
OSD topics:
ROSA topics:
Repo: Request cherrypick to enterprise-4.10 and enterprise-4.11