cluster_matrix1 Fix typo and add support for RHV IPI UPI compatibility in cluster matrix tables

[emarcusRH]

ISSUE:
Fix typo and add support for RHV IPI UPI compatibility for Restricted Networks in cluster matrix tables
(OpenShift guide > Installation introductory chapter)
This is a new PR - a followup PR to complete the broken PR #49082
(merge conflicts, extraneous branch/file added to commit by mistake)

Version(s):
enterprise-4.10
enterprise-4.11
enterprise-4.12

Issue:

Link to docs preview:
http://file.tlv.redhat.com/emarcus/cluster_matrix1/installing/installing-preparing.html#supported-installation-methods-for-different-platforms

Additional information:

comments/discussion/approvals from previous PR:

emarcusRH commented 7 days ago
@engelmi , @janosdebugs
I need someone to double check that the support for UPI on restricted networks exists in both 4.10 and 4.11.
In the installation instructions in the guide, it implies that both are supported - callout description #4 in this sample YAML file indicates that IPI is supported - https://docs.openshift.com/container-platform/4.11/installing/installing_rhv/installing-rhv-restricted-network.html#installation-bare-metal-config-yaml_installing-rhv-restricted-network
@engelmi
Member
engelmi commented 6 days ago

Based on the documentation for 4.10 and 4.11, I'd say yes - not sure how to verify this correctly. Can you help? @janosdebugs
@openshift-merge-robot openshift-merge-robot added needs-rebase and removed needs-rebase labels 6 days ago
@janosdebugs
Member
janosdebugs commented 6 days ago

Sadly, I don't know the answer. I have to assume that the previous version would be correct, but @peterclauterbach would probably know more.
@peterclauterbach
Member
peterclauterbach commented 6 days ago

I'm not sure I understand the question.
Once we support a deployment option, we continue to support it, unless it is explicitly deprecated.
Since it was it was supported in OCP 4.9, it is correct that support continues in OCP 4.10 and OCP 4.11.
@janosdebugs
Member
janosdebugs commented 6 days ago

I believe the question is between UPI and IPI: which one do we support for a restricted network installation?
@emarcusRH
Member Author
emarcusRH commented 6 days ago

I'm not sure I understand the question.
Once we support a deployment option, we continue to support it, unless it is explicitly deprecated. Since it was it was supported in OCP 4.9, it is correct that support continues in OCP 4.10 and OCP 4.11.

@peterclauterbach the instructions for OCP on RHV/restricted networks provides the procdure for UPI installations - https://docs.openshift.com/container-platform/4.11/installing/installing_rhv/installing-rhv-restricted-network.html#installation-network-user-infra_installing-rhv-restricted-network
But the support matrix in the general Installation chapter is missing an "X" under UPI/Restricted Networks > RHV
https://docs.openshift.com/container-platform/4.11/installing/installing-preparing.html#supported-installation-methods-for-different-platforms

is this simply an oversight that it was not updated?

@peterclauterbach
Member
peterclauterbach commented 6 days ago

Yes, it's an oversight. We support UPI installations on restricted networks. The bulk of UPI installations are direconnected.

[abrennan89]

LGTM but I'll ask someone else on the squad to take another look since this is my first week reviewing. Thanks!

[abrennan89]

@emarcusRH can you please update the title / format of the PR so that it references the issue also?

per the docs manual:

In the first comment of your PR, add a link to your bug or Jira issue. Once there is a preview available for your PR, edit the first comment to add the direct link to your content so it makes it easy for end users to review.

Structure your PR title like so:

[GH#][BZ][]:

See this PR for an example of an acceptable comment and title: https://github.com/openshift/openshift-docs/pull/30123

Remember to use unformatted links in the comment.

[emarcusRH]

@emarcusRH can you please update the title / format of the PR so that it references the issue also?

per the docs manual:

In the first comment of your PR, add a link to your bug or Jira issue. Once there is a preview available for your PR, edit the first comment to add the direct link to your content so it makes it easy for end users to review.
Structure your PR title like so:
[GH#][BZ][]:
See this PR for an example of an acceptable comment and title: https://github.com/openshift/openshift-docs/pull/30123
Remember to use unformatted links in the comment.

There isn't a bug associated with this issue - it came in as a personal request via Slack chat.

[tmalove]

LGTM

[abrennan89]

/cherrypick enterprise-4.12

[abrennan89]

/cherrypick enterprise-4.11

[abrennan89]

/cherrypick enterprise-4.10

[openshift-cherrypick-robot]

@abrennan89: new pull request created: #49554

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-cherrypick-robot]

@abrennan89: new pull request created: #49555

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-cherrypick-robot]

@abrennan89: new pull request created: #49556

In response to this:

/cherrypick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.