Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-3533 Adding note about vfio-pci #52851

Merged
merged 1 commit into from
Nov 17, 2022
Merged

OCPBUGS-3533 Adding note about vfio-pci #52851

merged 1 commit into from
Nov 17, 2022

Conversation

kquinn1204
Copy link
Contributor

@kquinn1204 kquinn1204 commented Nov 16, 2022 •
edited
Loading

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 16, 2022
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Nov 16, 2022 •
edited
Loading

🤖 Updated build preview is available at:
https://52851--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/3648

@kquinn1204
Copy link
Contributor Author

@SchSeba Can you review this PR. NOTE added in two places

@kquinn1204
Copy link
Contributor Author

@kononovn can you give a LGTM on this update requested by Sebastian please.

SchSeba
SchSeba approved these changes Nov 16, 2022
View reviewed changes
Copy link
Contributor

@SchSeba SchSeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 16, 2022
@kquinn1204
Copy link
Contributor Author

/label telco

@openshift-ci openshift-ci bot added the telco Label for all Telco PRs label Nov 16, 2022
@kquinn1204
Copy link
Contributor Author

/label peer-review-needed added clarification requested by developer

@kquinn1204
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Nov 16, 2022
@kcarmichael08
Copy link
Contributor

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Nov 16, 2022
@kcarmichael08
Copy link
Contributor

kcarmichael08 commented Nov 16, 2022 •
edited
Loading

Hi @kquinn1204 , should the sentence in callout # 9 for the YAML file in those 2 sections also be changed to remove vfio-pci as a supported type?

Optional: The driver type for the virtual functions. The only allowed values are netdevice and vfio-pci.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 16, 2022
@openshift-ci
Copy link

openshift-ci bot commented Nov 16, 2022

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 16, 2022
@kquinn1204
Copy link
Contributor Author

@kcarmichael08 made that update. I believe support is coming back for this, so will need to reinstate.

@kcarmichael08
Copy link
Contributor

LGTM

/remove-label peer-review-in-progress
/remove-label peer-review-needed
/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Nov 16, 2022
@kquinn1204
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Nov 17, 2022
@jboxman-rh jboxman-rh added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Nov 17, 2022
@jboxman-rh jboxman-rh added this to the Continuous Release milestone Nov 17, 2022
@jboxman-rh jboxman-rh merged commit 3dc58da into openshift:main Nov 17, 2022
@jboxman-rh
Copy link

/cherry-pick enterprise-4.12

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 17, 2022
Merged
@openshift-cherrypick-robot
Copy link

@jboxman-rh: new pull request created: #52935

In response to this:

/cherry-pick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jboxman-rh
Copy link

/cherry-pick enterprise-4.11

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 17, 2022
Merged
@openshift-cherrypick-robot
Copy link

@jboxman-rh: new pull request created: #52936

In response to this:

/cherry-pick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jboxman-rh jboxman-rh removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SchSeba SchSeba SchSeba approved these changes

Assignees

@SchSeba SchSeba

Labels
branch/enterprise-4.11 branch/enterprise-4.12 peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files. telco Label for all Telco PRs
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.
6 participants
@kquinn1204 @ocpdocs-previewbot @kcarmichael08 @jboxman-rh @openshift-cherrypick-robot @SchSeba