[OSDOCS-6943]:OSD-GCP: Purchasing OSD through GCP Marketplace #64901
Conversation
openshift-ci
bot
added
the
size/S
|
🤖 Updated build preview is available at: Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/26513 |
openshift-merge-robot
added
the
needs-rebase
openshift-ci
bot
added
size/L
mletalie
force-pushed
the
OSDOCS-6943
branch
from
9e31d94 to
bad058b
Compare
openshift-merge-robot
removed
the
needs-rebase
mletalie
force-pushed
the
OSDOCS-6943
branch
from
bad058b to
305f099
Compare
openshift-ci
bot
added
size/S
mletalie
changed the title
mletalie
force-pushed
the
OSDOCS-6943
branch
from
305f099 to
efc377f
Compare
openshift-ci
bot
added
size/M
mletalie
force-pushed
the
OSDOCS-6943
branch
from
457e5b4 to
fca59ae
Compare
|
We can reword this paragraph a bit. Current text:
Proposed change:
@abhgupta - what are your thoughts? |
|
The procedure looks okay, except # 4.b. Based on the recent updates to the UXD mockups, there will be a redirect link but no check box for the Google Terms and Agreements. The Google Terms and Agreements link will be opened in a separate tab. The user will have to agree to this and come back and continue with rest of the OSD cluster create wizard. The screenshot for this in captured in the UX design doc (step D)
|
|
Reviewed the following links. The content looks good. I will open it to the wider GCP squad working on this feature to provide their feedback. |
|
Hello @yasun, when you get a moment could you please provide a QE review for this PR? Thanks! |
| |Cloud infrastructure account | ||
| |Billed through | ||
|
|
||
| .2+|Annual fixed capacity subscriptions through Red Hat |Red Hat cloud account |
There was a problem hiding this comment.
I have no advice for this part but for the next two marketplace subscription type. From the design document, there are two kinds of subscription-types: Annual and On-demand, either google cloud marketplace or red hat marketplace is one type of On-demand. Could google cloud marketplace and red hat marketplace be at the same level of 'Annual'?
Besides, do not see Customer’s own Google Cloud account, there is Customer’s own cloud account for google cloud marketplace and red hat marketplace.
There was a problem hiding this comment.
@yasun1 - can you please clarify, what do you mean by -
Could google cloud marketplace and red hat marketplace be at the same level of 'Annual'?
I am little confused, because, Google Cloud Marketplace and Red Hat Marketplace cannot be at the same level as Annual. This is because, they are NOT annual and purely on-demand/consumption-based. Please let me know if I interpreted your comment incorrectly,
We decided to add three different rows to highlight the difference in infrastructure type and how many/who bills the customer.
There was a problem hiding this comment.
I am little confused, because, Google Cloud Marketplace and Red Hat Marketplace cannot be at the same level as Annual. This is because, they are NOT annual and purely on-demand/consumption-based. Please let me know if I interpreted your comment incorrectly,
Agree with you. So I was thinking that in the table, the first level is Annual -> On-demand, and on-demand is separated into Google Cloud Marketplace and Red Hat Marketplace.
Now, I rethink again, the current tab structure could be accepted too. Thanks.
| .. Click *Next*. | ||
| . On the *Cloud provider* page, read the provided prerequisites and the Google terms and conditions. Add your service account key. | ||
| .. Click the *Review Google Terms and Agreements* link. | ||
| .. If you agree to the Google terms and agreements and want to proceed, continue completing the steps in the {product-title} cluster create wizard. |
There was a problem hiding this comment.
It is If you agree.... If the customer wants to continue, it must accept the terms and agreements.
And after accepting the terms and agreements, do we still need to select the checkbox to acknowledge that you have read and completed all of the prerequisites?
There was a problem hiding this comment.
Good question. I have a question out to the mock-up designer to see what option the user has to make (ie radio button, checkbox, etc) once they read those terms and agreements.
There was a problem hiding this comment.
Got response, will update docs, there is a checkbox which needs to be selected to continue the process.
There was a problem hiding this comment.
Yes, we still need the checkbox at the end of the page. There is no change to this part i.e. to the placement of this checkbox. We are also added a specific call to action for reviewing Google terms and agreements as shown in this design doc https://docs.google.com/document/d/1xpRCZ0QYWRuvVtCEycWrHwXWSIepzUkgb8Nobqf3Dlc/edit#heading=h.ve1e69gtx5pl
| + | ||
| [NOTE] | ||
| ==== | ||
| After your cluster is created, you can change the number of compute nodes, but you cannot change the compute node instance type in a machine pool. For clusters that use the CCS model, you can add machine pools after installation that use a different instance type. The number and types of nodes available to you depend on your {product-title} subscription. |
There was a problem hiding this comment.
For this sentence:
you cannot change the compute node instance type in a created machine poolcould be more strict.- No need
For clusters that use the CCS model, either ccs or non-ccs, the customer can add the machine pool. use a customized instance typecould be better.
mletalie
force-pushed
the
OSDOCS-6943
branch
2 times, most recently
from
dbf9c86 to
8014522
Compare
|
Hello Peer Review Team! All the steps starting at step #5 were pulled from pre-existing docs (https://docs.openshift.com/dedicated/osd_install_access_delete_cluster/creating-a-gcp-cluster.html#osd-create-gcp-cluster-ccs_osd-creating-a-cluster-on-gcp, https://docs.openshift.com/dedicated/osd_install_access_delete_cluster/creating-a-gcp-cluster.html#osd-create-aws-cluster-ccs_osd-creating-a-cluster-on-gcp), so if you do make suggestions to that section of the docs I may open another ticket to address those concerns in those topics, but I do know this feature is going live next week. |
|
/label peer-review-needed |
openshift-ci
bot
added
the
peer-review-needed
+1. Let's open another OSDOCS story to capture feedback for existing steps/content. |
|
/label peer-review-in-progress |
openshift-ci
bot
added
the
peer-review-in-progress
openshift-ci
bot
removed
the
peer-review-needed
| . In the *Cloud* tab, click *Create cluster* in the *Red Hat OpenShift Dedicated* row. | ||
|
|
||
| . Under *Billing model*, configure the subscription type and infrastructure type: | ||
| .. Select the *On-Demand* subscription type. |
There was a problem hiding this comment.
There are two spaces between "subscription" and "type," but the spacing looks fine in the preview pages. Maybe this is one of those strange instances when an extra space is need to make one space appear in the rendered version.
|
|
||
| . Under *Billing model*, configure the subscription type and infrastructure type: | ||
| .. Select the *On-Demand* subscription type. | ||
| .. From the dropdown menu, select *Google Cloud Marketplace*. |
There was a problem hiding this comment.
- I'm guessing there's no label/name for the drop-down menu. If there is, use it, please.
- "Dropdown" should be hyphenated as per the IBM style guide.
| + | ||
| [NOTE] | ||
| ==== | ||
| By enabling etcd encryption for the key values in etcd, you will incur a performance overhead of approximately 20%. The overhead is a result of introducing this second layer of encryption, in addition to the default control plane storage encryption that encrypts the etcd volumes. Consider enabling etcd encryption only if you specifically require it for your use case. |
There was a problem hiding this comment.
Replace "you will incur" with "you incur."
As per the Red Hat Supplemental Style Guide:
| + | ||
| [NOTE] | ||
| ==== | ||
| You can review the end-of-life dates in the update life cycle documentation for {product-title}. For more information, see _{product-title} update life cycle_. |
There was a problem hiding this comment.
Lifecycle (two instances in this paragraph) is one word according to the IBM Style Guide.
| + | ||
| For information about administrator acknowledgment, see xref:./../upgrading/osd-upgrading-cluster-prepare.adoc#upgrade-49-acknowledgement_osd-updating-cluster-prepare[Administrator acknowledgment when upgrading to OpenShift 4.9]. | ||
| .. If you opted for recurring updates, select a preferred day of the week and upgrade start time in UTC from the drop-down menus. | ||
| .. Optional: You can set a grace period for *Node draining* during cluster upgrades. A *1 hour* grace period is set by default. |
There was a problem hiding this comment.
Are there minimum and maximum grace period settings?
There was a problem hiding this comment.
Not sure as this was pulled from previously published docs. That being said, I plan on opening another ticket which addresses some of the possible issues that come up when these docs were looked at it again for this topic. Thx
| In the event of critical security concerns that significantly impact the security or stability of a cluster, Red Hat Site Reliability Engineering (SRE) might schedule automatic updates to the latest z-stream version that is not impacted. The updates are applied within 48 hours after customer notifications are provided. For a description of the critical impact security rating, see link:https://access.redhat.com/security/updates/classification[Understanding Red Hat security ratings]. | ||
| ==== | ||
|
|
||
| . Review the summary of your selections and click *Create cluster* to start the cluster installation. The installation takes approximately 30-40 minutes to complete. |
There was a problem hiding this comment.
It's great that you included the approximate time!!!
There was a problem hiding this comment.
Would love to take credit but this was pulled from previously used docs :) :(
|
Hi, @mletalie. A few comments. Nothing major. Another general thought is that the linking text should match the name of the linked page so there's no confusion on the reader's part that they're in the right place. I noticed some of the text links were close enough, while some others were very different. It only took me a few seconds to determine I was in the right place, but those seconds can add up. :-) |
|
/remove-label peer-review-in-progress |
openshift-ci
bot
added
peer-review-done
Thanks @nalhadef, those are good points. We definitely do link a lot to outside sources, so I will speak with my team/CS about that, and see how they feel it should be handled. Thanks for that insight! |
|
/cherrypick enterprise-4.13 |
|
/cherrypick enterprise-4.14 |
|
@EricPonvelle: new pull request created: #66554 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@EricPonvelle: new pull request created: #66555 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Version(s):
4.13
Issue:
https://issues.redhat.com/browse/OSDOCS-6943
Link to docs preview:
https://64901--docspreview.netlify.app/openshift-dedicated/latest/osd_getting_started/osd-getting-started#osd-getting-started-create-cluster-ccs
https://64901--docspreview.netlify.app/openshift-dedicated/latest/osd_architecture/osd_policy/osd-service-definition
https://64901--docspreview.netlify.app/openshift-dedicated/latest/osd_install_access_delete_cluster/creating-a-gcp-cluster#osd-create-cluster-gcp-account_osd-creating-a-cluster-on-gcp
QE review:
Additional information: