Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OBSDOCS-702: Clarify available endpoint auth methods in user workload… #75588

Merged
merged 1 commit into from
Jun 3, 2024
Merged

OBSDOCS-702: Clarify available endpoint auth methods in user workload… #75588

merged 1 commit into from
Jun 3, 2024

Conversation

eromanova97
Copy link
Contributor

@eromanova97 eromanova97 commented May 7, 2024 •
edited
Loading

Version(s): enterprise-4.12 and later

Issue: OBSDOCS-702

Link to docs preview:
Example service endpoint authentication settings

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 7, 2024 •
edited by openshift-ci bot
Loading

@eromanova97: This pull request references OBSDOCS-702 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s): enterprise-4.12 and later

Issue: OBSDOCS-702

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 7, 2024
@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 7, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented May 7, 2024 •
edited
Loading

🤖 Mon Jun 03 09:05:32 - Prow CI generated the docs preview:

https://75588--ocpdocs-pr.netlify.app/openshift-dedicated/latest/observability/monitoring/configuring-the-monitoring-stack.html
https://75588--ocpdocs-pr.netlify.app/openshift-dedicated/latest/observability/monitoring/managing-metrics.html
https://75588--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/monitoring/configuring-the-monitoring-stack.html
https://75588--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/monitoring/managing-metrics.html
https://75588--ocpdocs-pr.netlify.app/openshift-rosa/latest/observability/monitoring/configuring-the-monitoring-stack.html
https://75588--ocpdocs-pr.netlify.app/openshift-rosa/latest/observability/monitoring/managing-metrics.html

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 7, 2024 •
edited by openshift-ci bot
Loading

@eromanova97: This pull request references OBSDOCS-702 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s): enterprise-4.12 and later

Issue: OBSDOCS-702

Link to docs preview:
Specifying how a service is monitored

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

simonpasquier
simonpasquier reviewed May 14, 2024
View reviewed changes
Copy link

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few points from me:

  • I don't think that we should modify the existing doc and add the authorization field as it would break the example.
  • Additional examples showing how to configure authorization, Basic-Auth and OAuth2 would be helpful (similar to what we have already for remote-write) though I understand that it's a bigger task.
  • In the scope of user-defined monitoring, the usage of bearerTokenFile isn't possible and indeed the ServiceMonitor object will be discarded by the operator.
  • The tools won't show bearerToken and bearerTokenFile as deprecated but we shouldn't use them in the documentation.

@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 15, 2024
@eromanova97 eromanova97 force-pushed the OBSDOCS-702 branch 3 times, most recently from 948dd72 to e9703a0 Compare May 15, 2024 07:43
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 15, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 15, 2024 •
edited by openshift-ci bot
Loading

@eromanova97: This pull request references OBSDOCS-702 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s): enterprise-4.12 and later

Issue: OBSDOCS-702

Link to docs preview:
Example service endpoint authentication settings

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@eromanova97 eromanova97 force-pushed the OBSDOCS-702 branch 2 times, most recently from 4933e90 to 2dd4732 Compare May 20, 2024 09:28
@juzhao
Copy link

juzhao commented May 20, 2024

LGTM, waiting for others to review

@eromanova97 eromanova97 force-pushed the OBSDOCS-702 branch 3 times, most recently from ad7d6bf to 3ac1351 Compare May 22, 2024 10:05
simonpasquier
simonpasquier reviewed May 30, 2024
View reviewed changes
Copy link

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@adellape
Copy link
Contributor

Dropping merge-review labels since I'll be off review squad next week. Please re-queue for merge when ready. Thank you!

@adellape adellape removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels May 31, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 3, 2024

@eromanova97: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@eromanova97
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jun 3, 2024
@skopacz1 skopacz1 added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Jun 3, 2024
skopacz1
skopacz1 approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@skopacz1 skopacz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge review LGTM!

@skopacz1 skopacz1 merged commit d9b33d1 into openshift:main Jun 3, 2024
3 checks passed
@skopacz1
Copy link
Contributor

skopacz1 commented Jun 3, 2024

/cherrypick enterprise-4.12

@skopacz1
Copy link
Contributor

skopacz1 commented Jun 3, 2024

/cherrypick enterprise-4.13

@skopacz1
Copy link
Contributor

skopacz1 commented Jun 3, 2024

/cherrypick enterprise-4.14

@skopacz1
Copy link
Contributor

skopacz1 commented Jun 3, 2024

/cherrypick enterprise-4.15

@skopacz1
Copy link
Contributor

skopacz1 commented Jun 3, 2024

/cherrypick enterprise-4.16

@openshift-cherrypick-robot
Copy link

@skopacz1: new pull request created: #76826

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

This was referenced Jun 3, 2024
Merged
Merged
@openshift-cherrypick-robot
Copy link

@skopacz1: new pull request created: #76827

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link

@skopacz1: new pull request created: #76828

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

This was referenced Jun 3, 2024
Merged
Merged
@openshift-cherrypick-robot
Copy link

@skopacz1: new pull request created: #76829

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link

@skopacz1: new pull request created: #76830

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 3, 2024
Merged
@eromanova97 eromanova97 deleted the OBSDOCS-702 branch June 4, 2024 06:18
@skopacz1 skopacz1 removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Jun 4, 2024
@eromanova97 eromanova97 mentioned this pull request Sep 20, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocpdocs-vale-bot ocpdocs-vale-bot ocpdocs-vale-bot left review comments

@mburke5678 mburke5678 mburke5678 left review comments

@juzhao juzhao juzhao left review comments

@adellape adellape adellape left review comments

@simonpasquier simonpasquier simonpasquier left review comments

@skopacz1 skopacz1 skopacz1 approved these changes

Assignees

@simonpasquier simonpasquier

@adellape adellape

Labels
branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.
10 participants
@eromanova97 @openshift-ci-robot @ocpdocs-previewbot @juzhao @adellape @skopacz1 @openshift-cherrypick-robot @simonpasquier @mburke5678 @ocpdocs-vale-bot