Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add entry for PVC configuration topic and section #8002

Closed
wants to merge 1 commit into from
Closed

Add entry for PVC configuration topic and section #8002

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Mar 2, 2018

@ahardin-rh Can you review this PR? This is to add an entry to the revision history for #7497. Thanks!

@ghost ghost added the peer-review-needed Signifies that the peer review team needs to review this PR label Mar 2, 2018
@ghost ghost added this to the Future Release milestone Mar 2, 2018
@ghost ghost self-assigned this Mar 2, 2018
@ghost ghost requested a review from ahardin-rh March 2, 2018 16:19
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 2, 2018
@@ -7,3 +7,15 @@
:experimental:

// do-release: revhist-tables

== Thu Feb 22 2018
// tag::<guide_dirname>_thu_feb_22_2018[]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've never used <guide_dirname>. Is this new?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahardin-rh
Copy link
Contributor

@tmorriso-rh Revision histories should be applied against the product branch that you cherry-picked to, not against the master branch. So, if this is going to be applied against enterprise-3.9, I would check out enterprise-3.9, then:
git fetch upstream enterrise-3.9
git rebase upstream/enterprise-3.9

This will get 3.9 all up to date. Then, you can create a new feature branch while on enterprise-3.9 so that the changes you make are applied against 3.9. So, while still on enterprise-3.9, something like:
git checkout -b PR7905-revhistory

make your changes, save and commit, then push PR7905-revhistory as normal, but you may need to adjust in the prompt in GitHub so that it is against 3.9. Let me know if you have any questions or if I can walk you though this.

@ahardin-rh
Copy link
Contributor

@tmorriso-rh Also, if this is for 3.9, then the revision histories should be listed under the March 21 date in that branch since that is the date that 3.9 will be released. When you checkout 3.9, you will see a table with entries from me and other writers in the full revision history under the March 21 date, so you should just add to that table.

cc @vikram-redhat That is the new guidance for 3.9, correct?

@ghost
Copy link
Author

ghost commented Mar 2, 2018

Thanks @ahardin-rh. I set up a work session for Monday.

@vikram-redhat
Copy link
Contributor

@tmorriso-rh + @ahardin-rh - yes that is correct. I have sent an email to clarify and will update the manual.

@ghost
Copy link
Author

ghost commented Mar 6, 2018

Work continued in #8025.

@ghost ghost closed this Mar 6, 2018
@ghost ghost removed the peer-review-needed Signifies that the peer review team needs to review this PR label Mar 14, 2018
@kalexand-rh kalexand-rh removed this from the Future Release milestone Aug 19, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants