-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add entry for PVC configuration topic and section #8002
Conversation
@@ -7,3 +7,15 @@ | |||
:experimental: | |||
|
|||
// do-release: revhist-tables | |||
|
|||
== Thu Feb 22 2018 | |||
// tag::<guide_dirname>_thu_feb_22_2018[] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've never used <guide_dirname>. Is this new?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I copied this from the revision history template: https://github.com/openshift/openshift-docs/blob/master/contributing_to_docs/templates/rev_history.adoc
@tmorriso-rh Revision histories should be applied against the product branch that you cherry-picked to, not against the master branch. So, if this is going to be applied against enterprise-3.9, I would check out enterprise-3.9, then: This will get 3.9 all up to date. Then, you can create a new feature branch while on enterprise-3.9 so that the changes you make are applied against 3.9. So, while still on enterprise-3.9, something like: make your changes, save and commit, then push PR7905-revhistory as normal, but you may need to adjust in the prompt in GitHub so that it is against 3.9. Let me know if you have any questions or if I can walk you though this. |
@tmorriso-rh Also, if this is for 3.9, then the revision histories should be listed under the March 21 date in that branch since that is the date that 3.9 will be released. When you checkout 3.9, you will see a table with entries from me and other writers in the full revision history under the March 21 date, so you should just add to that table. cc @vikram-redhat That is the new guidance for 3.9, correct? |
Thanks @ahardin-rh. I set up a work session for Monday. |
@tmorriso-rh + @ahardin-rh - yes that is correct. I have sent an email to clarify and will update the manual. |
Work continued in #8025. |
@ahardin-rh Can you review this PR? This is to add an entry to the revision history for #7497. Thanks!