Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSDOCS-9350-deepdive-3: endpointPublishingStrategy updates #80110

Merged
merged 1 commit into from
Sep 13, 2024
Merged

OSDOCS-9350-deepdive-3: endpointPublishingStrategy updates #80110

merged 1 commit into from
Sep 13, 2024

Conversation

dfitzmau
Copy link
Contributor

@dfitzmau dfitzmau commented Aug 7, 2024 •
edited
Loading

@openshift-ci-robot
Copy link

@dfitzmau: No Jira issue with key deepdive-3 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 7, 2024
@dfitzmau dfitzmau force-pushed the OSDOCS-9350-deepdive-3 branch from ed158ab to 9e48fc9 Compare August 7, 2024 10:48
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Aug 7, 2024 •
edited
Loading

🤖 Fri Sep 13 13:09:44 - Prow CI generated the docs preview:

https://80110--ocpdocs-pr.netlify.app/openshift-enterprise/latest/hosted_control_planes/hcp-deploy/hcp-deploy-virt.html
https://80110--ocpdocs-pr.netlify.app/openshift-enterprise/latest/machine_management/control_plane_machine_management/cpmso_provider_configurations/cpmso-config-options-aws.html
https://80110--ocpdocs-pr.netlify.app/openshift-enterprise/latest/machine_management/control_plane_machine_management/cpmso_provider_configurations/cpmso-config-options-azure.html
https://80110--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/configuring_ingress_cluster_traffic/configuring-ingress-cluster-traffic-ingress-controller.html
https://80110--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/configuring_ingress_cluster_traffic/configuring-ingress-cluster-traffic-load-balancer.html
https://80110--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/configuring_ingress_cluster_traffic/configuring-ingress-cluster-traffic-nodeport.html
https://80110--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/configuring_ingress_cluster_traffic/nw-configuring-ingress-controller-endpoint-publishing-strategy.html
https://80110--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/ingress-controller-dnsmgt.html
https://80110--ocpdocs-pr.netlify.app/openshift-enterprise/latest/post_installation_configuration/configuring-private-cluster.html

@dfitzmau dfitzmau force-pushed the OSDOCS-9350-deepdive-3 branch 5 times, most recently from a78482b to 9ef6c2b Compare August 7, 2024 12:00
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 7, 2024
@dfitzmau dfitzmau force-pushed the OSDOCS-9350-deepdive-3 branch 4 times, most recently from a47e37a to cded28f Compare August 7, 2024 14:34
@openshift-ci-robot
Copy link

@dfitzmau: No Jira issue with key deepdive-3 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to this:

Version(s):
4.12+

Issue:
(https://issues.redhat.com/browse/OSDOCS-9350)

Link to docs preview:

  • SME has approved this change.
  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dfitzmau dfitzmau force-pushed the OSDOCS-9350-deepdive-3 branch 14 times, most recently from 9915cc5 to 5de0305 Compare August 8, 2024 14:34
@lihongan
Copy link

LGTM. thank you @dfitzmau

@openshift-ci-robot
Copy link

@dfitzmau: No Jira issue with key deepdive-3 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to this:

Updates the doc to include Adding a NodePortService ingresscontroller from this SME document.

Version(s):
4.12+

Issue:
(https://issues.redhat.com/browse/OSDOCS-8653)

Link to docs preview:

Preview for link updates:

  • SME has approved this change.
  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dfitzmau dfitzmau force-pushed the OSDOCS-9350-deepdive-3 branch 6 times, most recently from 2006e99 to 014cb68 Compare September 13, 2024 13:01
@dfitzmau dfitzmau force-pushed the OSDOCS-9350-deepdive-3 branch from 014cb68 to c9d8a85 Compare September 13, 2024 13:02
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 13, 2024

@dfitzmau: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dfitzmau dfitzmau merged commit 3c13ab1 into openshift:main Sep 13, 2024
2 checks passed
@dfitzmau
Copy link
Contributor Author

/cherrypick enterprise-4.17

@dfitzmau
Copy link
Contributor Author

/cherrypick enterprise-4.16

@dfitzmau
Copy link
Contributor Author

/cherrypick enterprise-4.15

@dfitzmau
Copy link
Contributor Author

/cherrypick enterprise-4.14

@dfitzmau
Copy link
Contributor Author

/cherrypick enterprise-4.13

@dfitzmau
Copy link
Contributor Author

/cherrypick enterprise-4.12

@openshift-cherrypick-robot
Copy link

@dfitzmau: new pull request created: #81802

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 13, 2024
Merged
@openshift-cherrypick-robot
Copy link

@dfitzmau: #80110 failed to apply on top of branch "enterprise-4.16":

Applying: OSDOCS-9350-deepdive-3: endpointPublishingStrategy updates
.git/rebase-apply/patch:206: trailing whitespace.
Instead of creating a `NodePort`-type `Service` for each project, you can create a custom Ingress Controller to use the `NodePortService` endpoint publishing strategy. To prevent port conflicts, consider this configuration for your Ingress Controller when you want to apply a set of routes, through Ingress sharding, to nodes that might already have a `HostNetwork` Ingress Controller.  
.git/rebase-apply/patch:212: trailing whitespace.
* You must append the port that is assigned to the `NodePort`-type `Service` in the route so that you can access application pods. 
.git/rebase-apply/patch:246: trailing whitespace.
      type: NodePortService 
.git/rebase-apply/patch:316: trailing whitespace.
You must specify the domain name of your custom Ingress Controller in the `--hostname` argument. If you do not do this, the Ingress Operator uses the default Ingress Controller to serve all the routes for your cluster. 
.git/rebase-apply/patch:436: trailing whitespace.
// Creating a project and service  
warning: 5 lines add whitespace errors.
Using index info to reconstruct a base tree...
M	_topic_maps/_topic_map.yml
M	machine_management/control_plane_machine_management/cpmso_provider_configurations/cpmso-config-options-azure.adoc
A	modules/hcp-virt-wildcard-dns.adoc
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): modules/hcp-virt-wildcard-dns.adoc deleted in HEAD and modified in OSDOCS-9350-deepdive-3: endpointPublishingStrategy updates. Version OSDOCS-9350-deepdive-3: endpointPublishingStrategy updates of modules/hcp-virt-wildcard-dns.adoc left in tree.
Auto-merging machine_management/control_plane_machine_management/cpmso_provider_configurations/cpmso-config-options-azure.adoc
Auto-merging _topic_maps/_topic_map.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OSDOCS-9350-deepdive-3: endpointPublishingStrategy updates
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link

@dfitzmau: #80110 failed to apply on top of branch "enterprise-4.15":

Applying: OSDOCS-9350-deepdive-3: endpointPublishingStrategy updates
.git/rebase-apply/patch:206: trailing whitespace.
Instead of creating a `NodePort`-type `Service` for each project, you can create a custom Ingress Controller to use the `NodePortService` endpoint publishing strategy. To prevent port conflicts, consider this configuration for your Ingress Controller when you want to apply a set of routes, through Ingress sharding, to nodes that might already have a `HostNetwork` Ingress Controller.  
.git/rebase-apply/patch:212: trailing whitespace.
* You must append the port that is assigned to the `NodePort`-type `Service` in the route so that you can access application pods. 
.git/rebase-apply/patch:246: trailing whitespace.
      type: NodePortService 
.git/rebase-apply/patch:316: trailing whitespace.
You must specify the domain name of your custom Ingress Controller in the `--hostname` argument. If you do not do this, the Ingress Operator uses the default Ingress Controller to serve all the routes for your cluster. 
.git/rebase-apply/patch:436: trailing whitespace.
// Creating a project and service  
warning: 5 lines add whitespace errors.
Using index info to reconstruct a base tree...
M	_topic_maps/_topic_map.yml
M	machine_management/control_plane_machine_management/cpmso_provider_configurations/cpmso-config-options-azure.adoc
A	modules/hcp-virt-wildcard-dns.adoc
M	networking/configuring_ingress_cluster_traffic/configuring-ingress-cluster-traffic-ingress-controller.adoc
Falling back to patching base and 3-way merge...
Auto-merging networking/configuring_ingress_cluster_traffic/configuring-ingress-cluster-traffic-ingress-controller.adoc
CONFLICT (modify/delete): modules/hcp-virt-wildcard-dns.adoc deleted in HEAD and modified in OSDOCS-9350-deepdive-3: endpointPublishingStrategy updates. Version OSDOCS-9350-deepdive-3: endpointPublishingStrategy updates of modules/hcp-virt-wildcard-dns.adoc left in tree.
Auto-merging machine_management/control_plane_machine_management/cpmso_provider_configurations/cpmso-config-options-azure.adoc
Auto-merging _topic_maps/_topic_map.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OSDOCS-9350-deepdive-3: endpointPublishingStrategy updates
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link

@dfitzmau: #80110 failed to apply on top of branch "enterprise-4.14":

Applying: OSDOCS-9350-deepdive-3: endpointPublishingStrategy updates
.git/rebase-apply/patch:206: trailing whitespace.
Instead of creating a `NodePort`-type `Service` for each project, you can create a custom Ingress Controller to use the `NodePortService` endpoint publishing strategy. To prevent port conflicts, consider this configuration for your Ingress Controller when you want to apply a set of routes, through Ingress sharding, to nodes that might already have a `HostNetwork` Ingress Controller.  
.git/rebase-apply/patch:212: trailing whitespace.
* You must append the port that is assigned to the `NodePort`-type `Service` in the route so that you can access application pods. 
.git/rebase-apply/patch:246: trailing whitespace.
      type: NodePortService 
.git/rebase-apply/patch:316: trailing whitespace.
You must specify the domain name of your custom Ingress Controller in the `--hostname` argument. If you do not do this, the Ingress Operator uses the default Ingress Controller to serve all the routes for your cluster. 
.git/rebase-apply/patch:436: trailing whitespace.
// Creating a project and service  
warning: 5 lines add whitespace errors.
Using index info to reconstruct a base tree...
M	_topic_maps/_topic_map.yml
A	machine_management/control_plane_machine_management/cpmso_provider_configurations/cpmso-config-options-aws.adoc
A	machine_management/control_plane_machine_management/cpmso_provider_configurations/cpmso-config-options-azure.adoc
A	modules/hcp-virt-wildcard-dns.adoc
M	networking/configuring_ingress_cluster_traffic/configuring-ingress-cluster-traffic-ingress-controller.adoc
M	post_installation_configuration/configuring-private-cluster.adoc
Falling back to patching base and 3-way merge...
Auto-merging post_installation_configuration/configuring-private-cluster.adoc
Auto-merging networking/configuring_ingress_cluster_traffic/configuring-ingress-cluster-traffic-ingress-controller.adoc
CONFLICT (modify/delete): modules/hcp-virt-wildcard-dns.adoc deleted in HEAD and modified in OSDOCS-9350-deepdive-3: endpointPublishingStrategy updates. Version OSDOCS-9350-deepdive-3: endpointPublishingStrategy updates of modules/hcp-virt-wildcard-dns.adoc left in tree.
CONFLICT (modify/delete): machine_management/control_plane_machine_management/cpmso_provider_configurations/cpmso-config-options-azure.adoc deleted in HEAD and modified in OSDOCS-9350-deepdive-3: endpointPublishingStrategy updates. Version OSDOCS-9350-deepdive-3: endpointPublishingStrategy updates of machine_management/control_plane_machine_management/cpmso_provider_configurations/cpmso-config-options-azure.adoc left in tree.
CONFLICT (modify/delete): machine_management/control_plane_machine_management/cpmso_provider_configurations/cpmso-config-options-aws.adoc deleted in HEAD and modified in OSDOCS-9350-deepdive-3: endpointPublishingStrategy updates. Version OSDOCS-9350-deepdive-3: endpointPublishingStrategy updates of machine_management/control_plane_machine_management/cpmso_provider_configurations/cpmso-config-options-aws.adoc left in tree.
Auto-merging _topic_maps/_topic_map.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OSDOCS-9350-deepdive-3: endpointPublishingStrategy updates
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link

@dfitzmau: #80110 failed to apply on top of branch "enterprise-4.13":

Applying: OSDOCS-9350-deepdive-3: endpointPublishingStrategy updates
.git/rebase-apply/patch:206: trailing whitespace.
Instead of creating a `NodePort`-type `Service` for each project, you can create a custom Ingress Controller to use the `NodePortService` endpoint publishing strategy. To prevent port conflicts, consider this configuration for your Ingress Controller when you want to apply a set of routes, through Ingress sharding, to nodes that might already have a `HostNetwork` Ingress Controller.  
.git/rebase-apply/patch:212: trailing whitespace.
* You must append the port that is assigned to the `NodePort`-type `Service` in the route so that you can access application pods. 
.git/rebase-apply/patch:246: trailing whitespace.
      type: NodePortService 
.git/rebase-apply/patch:316: trailing whitespace.
You must specify the domain name of your custom Ingress Controller in the `--hostname` argument. If you do not do this, the Ingress Operator uses the default Ingress Controller to serve all the routes for your cluster. 
.git/rebase-apply/patch:436: trailing whitespace.
// Creating a project and service  
warning: 5 lines add whitespace errors.
Using index info to reconstruct a base tree...
M	_topic_maps/_topic_map.yml
A	machine_management/control_plane_machine_management/cpmso_provider_configurations/cpmso-config-options-aws.adoc
A	machine_management/control_plane_machine_management/cpmso_provider_configurations/cpmso-config-options-azure.adoc
A	modules/hcp-virt-wildcard-dns.adoc
M	networking/configuring_ingress_cluster_traffic/configuring-ingress-cluster-traffic-ingress-controller.adoc
M	post_installation_configuration/configuring-private-cluster.adoc
Falling back to patching base and 3-way merge...
Auto-merging post_installation_configuration/configuring-private-cluster.adoc
CONFLICT (content): Merge conflict in post_installation_configuration/configuring-private-cluster.adoc
Auto-merging networking/configuring_ingress_cluster_traffic/configuring-ingress-cluster-traffic-ingress-controller.adoc
CONFLICT (modify/delete): modules/hcp-virt-wildcard-dns.adoc deleted in HEAD and modified in OSDOCS-9350-deepdive-3: endpointPublishingStrategy updates. Version OSDOCS-9350-deepdive-3: endpointPublishingStrategy updates of modules/hcp-virt-wildcard-dns.adoc left in tree.
CONFLICT (modify/delete): machine_management/control_plane_machine_management/cpmso_provider_configurations/cpmso-config-options-azure.adoc deleted in HEAD and modified in OSDOCS-9350-deepdive-3: endpointPublishingStrategy updates. Version OSDOCS-9350-deepdive-3: endpointPublishingStrategy updates of machine_management/control_plane_machine_management/cpmso_provider_configurations/cpmso-config-options-azure.adoc left in tree.
CONFLICT (modify/delete): machine_management/control_plane_machine_management/cpmso_provider_configurations/cpmso-config-options-aws.adoc deleted in HEAD and modified in OSDOCS-9350-deepdive-3: endpointPublishingStrategy updates. Version OSDOCS-9350-deepdive-3: endpointPublishingStrategy updates of machine_management/control_plane_machine_management/cpmso_provider_configurations/cpmso-config-options-aws.adoc left in tree.
Auto-merging _topic_maps/_topic_map.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OSDOCS-9350-deepdive-3: endpointPublishingStrategy updates
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link

@dfitzmau: #80110 failed to apply on top of branch "enterprise-4.12":

Applying: OSDOCS-9350-deepdive-3: endpointPublishingStrategy updates
.git/rebase-apply/patch:206: trailing whitespace.
Instead of creating a `NodePort`-type `Service` for each project, you can create a custom Ingress Controller to use the `NodePortService` endpoint publishing strategy. To prevent port conflicts, consider this configuration for your Ingress Controller when you want to apply a set of routes, through Ingress sharding, to nodes that might already have a `HostNetwork` Ingress Controller.  
.git/rebase-apply/patch:212: trailing whitespace.
* You must append the port that is assigned to the `NodePort`-type `Service` in the route so that you can access application pods. 
.git/rebase-apply/patch:246: trailing whitespace.
      type: NodePortService 
.git/rebase-apply/patch:316: trailing whitespace.
You must specify the domain name of your custom Ingress Controller in the `--hostname` argument. If you do not do this, the Ingress Operator uses the default Ingress Controller to serve all the routes for your cluster. 
.git/rebase-apply/patch:436: trailing whitespace.
// Creating a project and service  
warning: 5 lines add whitespace errors.
Using index info to reconstruct a base tree...
M	_topic_maps/_topic_map.yml
A	machine_management/control_plane_machine_management/cpmso_provider_configurations/cpmso-config-options-aws.adoc
A	machine_management/control_plane_machine_management/cpmso_provider_configurations/cpmso-config-options-azure.adoc
A	modules/hcp-virt-wildcard-dns.adoc
M	networking/configuring_ingress_cluster_traffic/configuring-ingress-cluster-traffic-ingress-controller.adoc
M	post_installation_configuration/configuring-private-cluster.adoc
Falling back to patching base and 3-way merge...
Auto-merging post_installation_configuration/configuring-private-cluster.adoc
CONFLICT (content): Merge conflict in post_installation_configuration/configuring-private-cluster.adoc
Auto-merging networking/configuring_ingress_cluster_traffic/configuring-ingress-cluster-traffic-ingress-controller.adoc
CONFLICT (modify/delete): modules/hcp-virt-wildcard-dns.adoc deleted in HEAD and modified in OSDOCS-9350-deepdive-3: endpointPublishingStrategy updates. Version OSDOCS-9350-deepdive-3: endpointPublishingStrategy updates of modules/hcp-virt-wildcard-dns.adoc left in tree.
CONFLICT (modify/delete): machine_management/control_plane_machine_management/cpmso_provider_configurations/cpmso-config-options-azure.adoc deleted in HEAD and modified in OSDOCS-9350-deepdive-3: endpointPublishingStrategy updates. Version OSDOCS-9350-deepdive-3: endpointPublishingStrategy updates of machine_management/control_plane_machine_management/cpmso_provider_configurations/cpmso-config-options-azure.adoc left in tree.
CONFLICT (modify/delete): machine_management/control_plane_machine_management/cpmso_provider_configurations/cpmso-config-options-aws.adoc deleted in HEAD and modified in OSDOCS-9350-deepdive-3: endpointPublishingStrategy updates. Version OSDOCS-9350-deepdive-3: endpointPublishingStrategy updates of machine_management/control_plane_machine_management/cpmso_provider_configurations/cpmso-config-options-aws.adoc left in tree.
Auto-merging _topic_maps/_topic_map.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OSDOCS-9350-deepdive-3: endpointPublishingStrategy updates
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

This was referenced Sep 13, 2024
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpettyjo lpettyjo lpettyjo left review comments

@lihongan lihongan lihongan left review comments

@CFields651 CFields651 CFields651 left review comments

Assignees
No one assigned
Labels
branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 branch/enterprise-4.17 peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.
7 participants
@dfitzmau @openshift-ci-robot @ocpdocs-previewbot @CFields651 @lihongan @openshift-cherrypick-robot @lpettyjo