Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSDOCS#11775: Add missing step in 4.12 for replacing an unhealthy etcd member #80902

Conversation

tmalove
Copy link
Contributor

@tmalove tmalove commented Aug 26, 2024

Version(s):
4.12

Issue:
OSDOCS-11775

Link to docs preview Updated 8/26/24

QE review:

  • [x ] QE has approved this change.

Additional information:
This PR adds a new Step #3 in the procedure published in 4.13+, but not in 4.12.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 26, 2024
@ocpdocs-previewbot
Copy link

Copy link

openshift-ci bot commented Aug 26, 2024

@tmalove: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@tjungblu
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 27, 2024
@tmalove
Copy link
Contributor Author

tmalove commented Aug 27, 2024

Hi @geliu2016 will you review this PR to add a line in a procedure for 4.12? Thx.

@geliu2016
Copy link

/lgtm

@tmalove
Copy link
Contributor Author

tmalove commented Aug 28, 2024

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Aug 28, 2024
@mburke5678 mburke5678 added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Aug 28, 2024
+
[source,terminal]
----
$ oc delete node <node_name>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other steps in the procedure use actual values over . Should we do the same here?

Suggested change
$ oc delete node <node_name>
$ oc delete node ip-10-0-131-183.ec2.internal

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see now that this module in all other supported versions uses <node_name>. If you make this change, I guess it would need to be CP'd to all including main or rebasing this PR against main.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mburke5678 To get this out asap, I will go ahead with this PR as is, then create a new PR to change 4.12+ to your suggestion.

@mburke5678 mburke5678 added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Aug 28, 2024
@tmalove
Copy link
Contributor Author

tmalove commented Aug 28, 2024

@tjungblu what are your thoughts on making the CLI change that includes the specific node name versus the variable? Thanks!

@tjungblu
Copy link
Contributor

I have no particular preference for one over the other. If consistency is more important, feel free to pick the instance as an example

@tmalove
Copy link
Contributor Author

tmalove commented Aug 28, 2024

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Aug 28, 2024
@jldohmann jldohmann added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Aug 28, 2024
@jldohmann jldohmann added this to the Continuous Release milestone Aug 28, 2024
Copy link
Contributor

@jldohmann jldohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 🥳

@jldohmann jldohmann merged commit 5fa9330 into openshift:enterprise-4.12 Aug 28, 2024
2 checks passed
@jldohmann jldohmann removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.12 lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants