-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSDOCS#11775: Add missing step in 4.12 for replacing an unhealthy etcd member #80902
OSDOCS#11775: Add missing step in 4.12 for replacing an unhealthy etcd member #80902
Conversation
🤖 Mon Aug 26 17:50:15 - Prow CI generated the docs preview: |
@tmalove: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/lgtm |
Hi @geliu2016 will you review this PR to add a line in a procedure for 4.12? Thx. |
/lgtm |
/label peer-review-needed |
+ | ||
[source,terminal] | ||
---- | ||
$ oc delete node <node_name> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other steps in the procedure use actual values over . Should we do the same here?
$ oc delete node <node_name> | |
$ oc delete node ip-10-0-131-183.ec2.internal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see now that this module in all other supported versions uses <node_name>. If you make this change, I guess it would need to be CP'd to all including main
or rebasing this PR against main
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mburke5678 To get this out asap, I will go ahead with this PR as is, then create a new PR to change 4.12+ to your suggestion.
@tjungblu what are your thoughts on making the CLI change that includes the specific node name versus the variable? Thanks! |
I have no particular preference for one over the other. If consistency is more important, feel free to pick the instance as an example |
/label merge-review-needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! 🥳
Version(s):
4.12
Issue:
OSDOCS-11775
Link to docs preview Updated 8/26/24
QE review:
Additional information:
This PR adds a new Step #3 in the procedure published in 4.13+, but not in 4.12.