Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSDOCS-5243 Adding CLI Manager docs #81448

Merged
merged 1 commit into from
Nov 19, 2024
Merged

OSDOCS-5243 Adding CLI Manager docs #81448

merged 1 commit into from
Nov 19, 2024

Conversation

cbippley
Copy link
Contributor

@cbippley cbippley commented Sep 6, 2024 •
edited
Loading

Version(s): 4.17+

Issue: OSDOCS-5243

Link to docs preview: https://81448--ocpdocs-pr.netlify.app/openshift-enterprise/latest/cli_reference/cli_manager/

QE review:

  • QE has approved this change.

Additional information: TP debut on November 19th.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 6, 2024
@cbippley
Copy link
Contributor Author

cbippley commented Sep 6, 2024

/retest

@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Sep 6, 2024 •
edited
Loading

🤖 Tue Nov 19 20:14:57 - Prow CI generated the docs preview:
https://81448--ocpdocs-pr.netlify.app
Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

@cbippley cbippley force-pushed the OSDOCS-5243 branch 2 times, most recently from 79b89f6 to a539b7f Compare September 6, 2024 18:52
@cbippley cbippley force-pushed the OSDOCS-5243 branch 2 times, most recently from 65207e8 to b371519 Compare September 20, 2024 18:50
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 3, 2024
@cbippley cbippley force-pushed the OSDOCS-5243 branch 2 times, most recently from 5dd410c to 1f3b7f6 Compare October 7, 2024 18:35
@cbippley cbippley force-pushed the OSDOCS-5243 branch 4 times, most recently from 30aa131 to 4fee63d Compare October 15, 2024 13:53
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 15, 2024
@cbippley
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Nov 15, 2024
@lahinson lahinson added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Nov 15, 2024
lahinson
lahinson reviewed Nov 15, 2024
View reviewed changes
Copy link
Contributor

@lahinson lahinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good! I had just a few comments for your consideration.

cli_reference/cli_manager/index.adoc Show resolved Hide resolved
modules/cli-manager-about.adoc Outdated Show resolved Hide resolved
cli_reference/cli_manager/cli-manager-release-notes.adoc Outdated Show resolved Hide resolved
cli_reference/cli_manager/cli-manager-release-notes.adoc Outdated Show resolved Hide resolved
cli_reference/cli_manager/cli-manager-install.adoc Outdated Show resolved Hide resolved
modules/cli-manager-adding-plugin-yaml.adoc Outdated Show resolved Hide resolved
cli_reference/cli_manager/cli-manager-uninstall.adoc Outdated Show resolved Hide resolved
cli_reference/cli_manager/cli-manager-using.adoc Outdated Show resolved Hide resolved
modules/cli-manager-remove-resources.adoc Outdated Show resolved Hide resolved
modules/cli-manager-uninstalling.adoc Outdated Show resolved Hide resolved
@lahinson lahinson added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Nov 15, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 18, 2024

New changes are detected. LGTM label has been removed.

@cbippley
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Nov 19, 2024
@cbippley cbippley changed the title OSDOCS-5243 Adding CLI Manager docs OSDOCS-5243 Adding CLI Manager docs (release today) Nov 19, 2024
@stevsmit stevsmit added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Nov 19, 2024
@cbippley cbippley changed the title OSDOCS-5243 Adding CLI Manager docs (release today) OSDOCS-5243 Adding CLI Manager docs Nov 19, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 19, 2024

@cbippley: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@stevsmit stevsmit merged commit 499c014 into openshift:main Nov 19, 2024
2 checks passed
@stevsmit
Copy link
Member

/cherry-pick enterprise-4.17

@stevsmit
Copy link
Member

/cherry-pick enterprise-4.18

@openshift-cherrypick-robot
Copy link

@stevsmit: new pull request created: #85170

In response to this:

/cherry-pick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 19, 2024
Merged
@openshift-cherrypick-robot
Copy link

@stevsmit: new pull request created: #85171

In response to this:

/cherry-pick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocpdocs-vale-bot ocpdocs-vale-bot ocpdocs-vale-bot left review comments

@lahinson lahinson lahinson left review comments

@stevsmit stevsmit stevsmit left review comments

@ardaguclu ardaguclu ardaguclu left review comments

@bergerhoffer bergerhoffer bergerhoffer left review comments

@kasturinarra kasturinarra kasturinarra left review comments

@adellape adellape adellape left review comments

Assignees

@kasturinarra kasturinarra

Labels
branch/enterprise-4.17 branch/enterprise-4.18 merge-review-in-progress Signifies that the merge review team is reviewing this PR peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.