-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS#37081: Added OVN RN update #81666
Conversation
@dfitzmau: This pull request references Jira Issue OCPBUGS-37081, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@dfitzmau: No Jira issue is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
🤖 Tue Sep 17 10:43:17 - Prow CI generated the docs preview: |
61b7b69
to
43de14a
Compare
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A little type in the title, other than that all good! :)
43de14a
to
0d70239
Compare
/label peer-review-needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks, Darragh!
For 4.14.0 this looks good but we just backported changes allowing these values to be configurable https://issues.redhat.com/browse/OCPBUGS-41360 Now I am thinking we might need to mention them like those are configurable in 4.14z and 4.15 z as well. Also good to mention IPv6 reserved range as well as more and more customers are now trying IPv6? |
0d70239
to
2f4f251
Compare
@dfitzmau: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
As discussed with @dfitzmau regarding z stream notes /lgtm |
…4 risk The risk is briefly covered in the linked release note since 2024-09-18 [1]. I'm setting autoExtend, because unless some future 4.13.z addresses this (unlikely, with 4.13.z going end-of-life on 2014-11-27 [2]), or a future 4.14.z addresses this, we'll likely have to continue to carry it forward to every 4.13-to-4.14 update we ever support. This will make life more difficult for customers who traditionally wait until there's an update we recommend unconditionally. All OVN cluster administrators on 4.13 will need to read through the risk message and linked docs, and decide for themselves whether they are comfortable accepting the risk and updating to 4.14. Generated by writing the 4.14.0 risk by hand, and then copying out to all existing 4.14.z update targets with: $ curl -s 'https://api.openshift.com/api/upgrades_info/graph?channel=candidate-4.14&arch=amd64' | jq -r '.nodes[] | .version' | grep '^4[.]14[.][0-9]*$' | grep -v 4.14.0 | while read VERSION; do sed "s/4.14.0/${VERSION}/" blocked-edges/4.14.0-OVNTransitSwitchSubset.yaml > "blocked-edges/${VERSION}-OVNTransitSwitchSubset.yaml"; done [1]: openshift/openshift-docs#81666 (comment) [2]: https://access.redhat.com/support/policy/updates/openshift#dates
Version(s):
4.14
Issue:
OCPBUGS-37081
Link to docs preview:
4.14.0
Additional information: