-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSDOCS#11885: Sigstore signature RN #81997
Conversation
@skopacz1: This pull request references OSDOCS-11885 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
🤖 Mon Sep 23 16:56:32 - Prow CI generated the docs preview: |
@skopacz1: No Jira issue is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
11ee7c2
to
a57613e
Compare
@dis016 and @lyman9966 could you PTAL when you have a chance? Thanks! |
/lgtm |
[id="ocp-17-sigstore-verification_{context}"] | ||
==== Sigstore signature image verification | ||
|
||
With this release, Technology Preview clusters use Sigstore signatures to verify images that were retrieved using a pull spec that references `quay.io/openshift-release-dev/ocp-release`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit that you could take/leave:
With this release, Technology Preview clusters use Sigstore signatures to verify images that were retrieved using a pull spec that references `quay.io/openshift-release-dev/ocp-release`. | |
With this release, Technology Preview clusters use Sigstore signatures to verify images that were retrieved using a pull spec that references the `quay.io/openshift-release-dev/ocp-release` image. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I spoke with @wking and I'll implement the spirit of this feedback, however "the quay.io/openshift-release-dev/ocp-release
repository" would be more technically accurate here.
a57613e
to
5fb4048
Compare
New changes are detected. LGTM label has been removed. |
@skopacz1: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
OSDOCS-11885
Version(s): 4.17
This PR adds a release note about Sigstore image verification for core cluster images.
QE review:
Preview: https://81997--ocpdocs-pr.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-17-release-notes.html#ocp-17-sigstore-verification_release-notes