-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSDOCS-12422#VolumeAttributesClass TP #85302
base: main
Are you sure you want to change the base?
Conversation
modules/storage-persistent-storage-pvc-volumeattributesclass.adoc
Outdated
Show resolved
Hide resolved
modules/storage-persistent-storage-pvc-volumeattributesclass.adoc
Outdated
Show resolved
Hide resolved
modules/storage-persistent-storage-pvc-volumeattributesclass.adoc
Outdated
Show resolved
Hide resolved
383e827
to
2f711c3
Compare
modules/storage-persistent-storage-pvc-volumeattributesclass.adoc
Outdated
Show resolved
Hide resolved
modules/storage-persistent-storage-pvc-volumeattributesclass.adoc
Outdated
Show resolved
Hide resolved
modules/storage-persistent-storage-pvc-volumeattributesclass.adoc
Outdated
Show resolved
Hide resolved
|
||
To apply a Volume Attribute Class to a PVC: | ||
|
||
* Set the PVC's `volumeAttributesClassName` parameter to the Volume Attribute Class's name: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
restate that this field can be update on existing bound PVC? @gnufied
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
modules/storage-persistent-storage-pvc-volumeattributesclass.adoc
Outdated
Show resolved
Hide resolved
modules/storage-persistent-storage-pvc-volumeattributesclass.adoc
Outdated
Show resolved
Hide resolved
94d4f74
to
2f2ca1b
Compare
/label peer-review-in-progress |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, only one small nit.
modules/storage-persistent-storage-pvc-volumeattributesclass.adoc
Outdated
Show resolved
Hide resolved
/label peer-review-done |
2f2ca1b
to
d627003
Compare
if openshift/gcp-pd-csi-driver#75 merges please add GCP PD to the list of drivers that support this feature. |
:FeatureName: Volume Attributes Classes | ||
include::snippets/technology-preview.adoc[leveloffset=+1] | ||
|
||
Volume Attributes Classes in {product-title} is available only with AWS Elastic Block Storage (EBS) Container Storage Interface (CSI). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is now available with GCP-PD CSI driver too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added GCP.
@lpettyjo: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Version(s): 4.19
Issue: https://issues.redhat.com/browse/OSDOCS-12422
Link to docs preview: https://85302--ocpdocs-pr.netlify.app/openshift-enterprise/latest/storage/understanding-persistent-storage.html#storage-persistent-storage-pvc-volumeattributesclass_understanding-persistent-storage
QE review:
Additional information:
PTAL: @jsafrane @gcharot @radeore @chao007