Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSDOCS-12422#VolumeAttributesClass TP #85302

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lpettyjo
Copy link
Contributor

@lpettyjo lpettyjo commented Nov 21, 2024

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 21, 2024
@lpettyjo lpettyjo added branch/enterprise-4.18 peer-review-needed Signifies that the peer review team needs to review this PR labels Nov 21, 2024
@lpettyjo lpettyjo added this to the Planned for 4.18 GA milestone Nov 21, 2024

To apply a Volume Attribute Class to a PVC:

* Set the PVC's `volumeAttributesClassName` parameter to the Volume Attribute Class's name:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

restate that this field can be update on existing bound PVC? @gnufied

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@lpettyjo lpettyjo force-pushed the OSDOCS-12422 branch 4 times, most recently from 94d4f74 to 2f2ca1b Compare November 23, 2024 01:17
@GroceryBoyJr
Copy link
Contributor

/label peer-review-in-progress
/remove-label peer-review-needed
/assign GroceryBoyJr

@openshift-ci openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Nov 23, 2024
Copy link
Contributor

@GroceryBoyJr GroceryBoyJr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only one small nit.

@GroceryBoyJr
Copy link
Contributor

/label peer-review-done
/remove-label peer-review-in-progress
/unassign GroceryBoyJr

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Nov 23, 2024
@gcharot
Copy link

gcharot commented Mar 14, 2025

if openshift/gcp-pd-csi-driver#75 merges please add GCP PD to the list of drivers that support this feature.

:FeatureName: Volume Attributes Classes
include::snippets/technology-preview.adoc[leveloffset=+1]

Volume Attributes Classes in {product-title} is available only with AWS Elastic Block Storage (EBS) Container Storage Interface (CSI).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now available with GCP-PD CSI driver too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added GCP.

Copy link

openshift-ci bot commented Mar 18, 2025

@lpettyjo: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.19 peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants