Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RHACS] [Docs] ROX-28722: Release notes for 4.6.4 #91187

Closed
wants to merge 2 commits into from
Closed

[RHACS] [Docs] ROX-28722: Release notes for 4.6.4 #91187

wants to merge 2 commits into from

Conversation

agantony
Copy link
Contributor

@agantony agantony commented Mar 27, 2025 •
edited
Loading

Version(s):
4.6

Issue:
https://issues.redhat.com/browse/ROX-28722

Link to docs preview:
https://91187--ocpdocs-pr.netlify.app/openshift-acs/latest/release_notes/46-release-notes.html#about-release-464_release-notes-46

SME review:

  • SME has approved this change.

Additional information:

  • Merge into rhacs-docs-4.6

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 27, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 27, 2025 •
edited by openshift-ci bot
Loading

@agantony: This pull request references ROX-28722 which is a valid jira issue.

In response to this:

Version(s):
4.6

Issue:
https://issues.redhat.com/browse/ROX-28722

Link to docs preview:

SME review:

  • SME has approved this change.

Additional information:

  • Merge into rhacs-docs-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 27, 2025
@agantony agantony added RHACS Label for RHACS related PRs that go in the rhacs-docs branch rhacs-docs-4.6 labels Mar 27, 2025
@agantony agantony added this to the Continuous Release milestone Mar 27, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Mar 27, 2025 •
edited
Loading

🤖 Mon Mar 31 18:23:52 - Prow CI generated the docs preview:

https://91187--ocpdocs-pr.netlify.app/openshift-acs/latest/release_notes/46-release-notes.html

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 27, 2025 •
edited by openshift-ci bot
Loading

@agantony: This pull request references ROX-28722 which is a valid jira issue.

In response to this:

Version(s):
4.6

Issue:
https://issues.redhat.com/browse/ROX-28722

Link to docs preview:
https://91187--ocpdocs-pr.netlify.app/openshift-acs/latest/release_notes/46-release-notes.html#about-release-464_release-notes-46

SME review:

  • SME has approved this change.

Additional information:

  • Merge into rhacs-docs-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@agantony
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Mar 27, 2025
@lahinson lahinson added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 27, 2025
lahinson
lahinson reviewed Mar 27, 2025
View reviewed changes
Copy link
Contributor

@lahinson lahinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just one very tiny nit.

release_notes/46-release-notes.adoc
*Release date*: 31 March 2025

This release of {product-title-short} fixes the following
bugs:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the preview, this looks fine, but I'm guessing this lead-in sentence should all be on the same line in the code.

@lahinson lahinson added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Mar 27, 2025
lahinson
lahinson reviewed Mar 27, 2025
View reviewed changes
Copy link
Contributor

@lahinson lahinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, be sure to squash your commits :)

@kcarmichael08 kcarmichael08 force-pushed the ROX28722-rhacs-docs-4.6 branch from 62ee64c to 327b08f Compare March 31, 2025 18:13
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 31, 2025

@agantony: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kcarmichael08 kcarmichael08 mentioned this pull request Mar 31, 2025
Merged
@kcarmichael08
Copy link
Contributor

replaced with #91354 to squash commits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahinson lahinson lahinson left review comments

@rhybrillou rhybrillou rhybrillou approved these changes

Assignees
No one assigned
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR RHACS Label for RHACS related PRs that go in the rhacs-docs branch rhacs-docs-4.6 size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.
6 participants
@agantony @openshift-ci-robot @ocpdocs-previewbot @kcarmichael08 @rhybrillou @lahinson