Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Identify fail forward in csvSources (#2743) #290

Merged
merged 2 commits into from
Apr 19, 2022
Merged

Identify fail forward in csvSources (#2743) #290

merged 2 commits into from
Apr 19, 2022

Conversation

awgreene
Copy link
Contributor

This commit undos changes to the Resolve and ResolveSteps methods and
updats the csvSourceProvider to infer whether or not fail forward is
enabled in a namespace.

Signed-off-by: Alexander Greene greene.al1991@gmail.com

Upstream-repository: operator-lifecycle-manager
Upstream-commit: 462ce61fb6b0ac4e5c623d173bd38fed18b6468f

@awgreene
Identify fail forward in csvSources (#2743)
da2b9b2 
This commit undos changes to the Resolve and ResolveSteps methods and
updats the csvSourceProvider to infer whether or not fail forward is
enabled in a namespace.

Signed-off-by: Alexander Greene <greene.al1991@gmail.com>

Upstream-repository: operator-lifecycle-manager
Upstream-commit: 462ce61fb6b0ac4e5c623d173bd38fed18b6468f
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 18, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awgreene, tylerslaton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 18, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 18, 2022
@awgreene
Copy link
Contributor Author

/retest

1 similar comment
@awgreene
Copy link
Contributor Author

/retest

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@awgreene
Address fail forward unit test failures (#2747)
72d6b3e 
The broken replacement chain unit test occasionally fails because it is
possible for either the a.v1 or a.v2 operators to cause the resolver to
fail. This commit updates the test to check that the resolver fails
because a csv is in the failed state versus checking that a specific
csv is in the failed state.

Signed-off-by: Alexander Greene <greene.al1991@gmail.com>

Upstream-repository: operator-lifecycle-manager
Upstream-commit: c36183ef17f757dbf1f96a2619a2a91184afc579
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 18, 2022
@awgreene
Copy link
Contributor Author

/retest

2 similar comments
@awgreene
Copy link
Contributor Author

/retest

@awgreene
Copy link
Contributor Author

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 18, 2022

@awgreene: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@perdasilva
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 19, 2022
@openshift-merge-robot openshift-merge-robot merged commit f70f4d6 into openshift:master Apr 19, 2022
stevekuznetsov pushed a commit to stevekuznetsov/operator-framework-olm that referenced this pull request Aug 16, 2023
@tmshort @stevekuznetsov
[chore] Update github.com/emicklei/go-restful/v3 to v3.10.2 (openshif…
46536b8 
…t#290)

Fixes path join issue

Signed-off-by: Todd Short <todd.short@me.com>
Upstream-repository: api
Upstream-commit: 775e6c6534b89dde01826627ceb570c16ab6768f
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@stevekuznetsov stevekuznetsov mentioned this pull request Aug 17, 2023
Closed
stevekuznetsov added a commit to stevekuznetsov/operator-framework-olm that referenced this pull request Aug 17, 2023
@stevekuznetsov
[chore] Update github.com/emicklei/go-restful/v3 to v3.10.2 (openshif…
de54f9f 
…t#290)

Fixes path join issue

Signed-off-by: Todd Short <todd.short@me.com>
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
Upstream-repository: api
Upstream-commit: 775e6c6534b89dde01826627ceb570c16ab6768f
stevekuznetsov pushed a commit to stevekuznetsov/operator-framework-olm that referenced this pull request Aug 17, 2023
@tmshort @stevekuznetsov
[chore] Update github.com/emicklei/go-restful/v3 to v3.10.2 (openshif…
bfec560 
…t#290)

Fixes path join issue

Signed-off-by: Todd Short <todd.short@me.com>
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
Upstream-repository: api
Upstream-commit: 775e6c6534b89dde01826627ceb570c16ab6768f
stevekuznetsov pushed a commit to stevekuznetsov/operator-framework-olm that referenced this pull request Aug 17, 2023
@tmshort @stevekuznetsov
[chore] Update github.com/emicklei/go-restful/v3 to v3.10.2 (openshif…
25b2b21 
…t#290)

Fixes path join issue

Signed-off-by: Todd Short <todd.short@me.com>
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
Upstream-repository: api
Upstream-commit: 775e6c6534b89dde01826627ceb570c16ab6768f
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
stevekuznetsov pushed a commit to stevekuznetsov/operator-framework-olm that referenced this pull request Aug 17, 2023
@tmshort @stevekuznetsov
[chore] Update github.com/emicklei/go-restful/v3 to v3.10.2 (openshif…
e00649b 
…t#290)

Fixes path join issue

Signed-off-by: Todd Short <todd.short@me.com>
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
Upstream-repository: api
Upstream-commit: 775e6c6534b89dde01826627ceb570c16ab6768f
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
simonpasquier pushed a commit to simonpasquier/operator-framework-olm that referenced this pull request Aug 24, 2023
@tmshort @simonpasquier
[chore] Update github.com/emicklei/go-restful/v3 to v3.10.2 (openshif…
509b2d3 
…t#290)

Fixes path join issue

Signed-off-by: Todd Short <todd.short@me.com>
Upstream-repository: api
Upstream-commit: 775e6c6534b89dde01826627ceb570c16ab6768f
@openshift-bot openshift-bot mentioned this pull request Sep 9, 2023
Closed
openshift-bot pushed a commit to openshift-bot/operator-framework-olm that referenced this pull request Sep 9, 2023
@tmshort
[chore] Update github.com/emicklei/go-restful/v3 to v3.10.2 (openshif…
d65db87 
…t#290)

Fixes path join issue

Signed-off-by: Todd Short <todd.short@me.com>
Upstream-repository: api
Upstream-commit: 775e6c6534b89dde01826627ceb570c16ab6768f
openshift-bot pushed a commit to openshift-bot/operator-framework-olm that referenced this pull request Sep 14, 2023
@tmshort
[chore] Update github.com/emicklei/go-restful/v3 to v3.10.2 (openshif…
0d39482 
…t#290)

Fixes path join issue

Signed-off-by: Todd Short <todd.short@me.com>
Upstream-repository: api
Upstream-commit: 775e6c6534b89dde01826627ceb570c16ab6768f
openshift-bot pushed a commit to openshift-bot/operator-framework-olm that referenced this pull request Sep 15, 2023
@tmshort
[chore] Update github.com/emicklei/go-restful/v3 to v3.10.2 (openshif…
984083b 
…t#290)

Fixes path join issue

Signed-off-by: Todd Short <todd.short@me.com>
Upstream-repository: api
Upstream-commit: 775e6c6534b89dde01826627ceb570c16ab6768f
openshift-bot pushed a commit to openshift-bot/operator-framework-olm that referenced this pull request Sep 19, 2023
@tmshort
[chore] Update github.com/emicklei/go-restful/v3 to v3.10.2 (openshif…
d02b421 
…t#290)

Fixes path join issue

Signed-off-by: Todd Short <todd.short@me.com>
Upstream-repository: api
Upstream-commit: 775e6c6534b89dde01826627ceb570c16ab6768f
stevekuznetsov pushed a commit to stevekuznetsov/operator-framework-olm that referenced this pull request Sep 22, 2023
@tmshort @stevekuznetsov
[chore] Update github.com/emicklei/go-restful/v3 to v3.10.2 (openshif…
86b5fb7 
…t#290)

Fixes path join issue

Signed-off-by: Todd Short <todd.short@me.com>
Upstream-repository: api
Upstream-commit: 775e6c6534b89dde01826627ceb570c16ab6768f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylerslaton tylerslaton tylerslaton approved these changes

@timflannagan timflannagan timflannagan approved these changes

@joelanford joelanford Awaiting requested review from joelanford

@kevinrizza kevinrizza Awaiting requested review from kevinrizza

Assignees

@perdasilva perdasilva

@tylerslaton tylerslaton

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@awgreene @openshift-bot @perdasilva @timflannagan @tylerslaton @openshift-merge-robot