Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Removing HTMLService and linkify filter as they're now in common #1625

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion app/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,6 @@ <h1>JavaScript Required</h1>
<script src="scripts/services/catalog.js"></script>
<script src="scripts/services/modals.js"></script>
<script src="scripts/services/cliHelp.js"></script>
<script src="scripts/services/html.js"></script>
<script src="scripts/services/environment.js"></script>
<script src="scripts/services/keyValueEditorProvider.js"></script>
<script src="scripts/services/keyValueEditorUtils.js"></script>
Expand Down
9 changes: 0 additions & 9 deletions app/scripts/app.js
Original file line number Diff line number Diff line change
Expand Up @@ -436,15 +436,6 @@ angular
.constant("LOGGING_URL", _.get(window.OPENSHIFT_CONFIG, "loggingURL"))
.constant("METRICS_URL", _.get(window.OPENSHIFT_CONFIG, "metricsURL"))
.constant("LIMIT_REQUEST_OVERRIDES", _.get(window.OPENSHIFT_CONFIG, "limitRequestOverrides"))
// Sometimes we need to know the css breakpoints, make sure to update this
// if they ever change!
.constant("BREAKPOINTS", {
screenXsMin: 480, // screen-xs
screenSmMin: 768, // screen-sm
screenMdMin: 992, // screen-md
screenLgMin: 1200, // screen-lg
screenXlgMin: 1600 // screen-xlg
})
// A (very) basic regex to determine if a URL is an absolute URL, enough to
// warn the user the Git URL probably won't work. This should only be used
// as a sanity test and shouldn't block submitting the form. Rely on the API
Expand Down
12 changes: 0 additions & 12 deletions app/scripts/filters/util.js
Original file line number Diff line number Diff line change
Expand Up @@ -495,18 +495,6 @@ angular.module('openshiftConsole')
.filter('encodeURIComponent', function() {
return window.encodeURIComponent;
})
// Usage: <span ng-bind-html="text | linkify : '_blank'"></span>
//
// Prefer this to the AngularJS `linky` filter since it only matches http and
// https URLs. We've had issues with incorretly matching email addresses.
//
// https://github.com/openshift/origin-web-console/issues/315
// See also HTMLService.linkify
.filter('linkify', function(HTMLService) {
return function(text, target, alreadyEscaped) {
return HTMLService.linkify(text, target, alreadyEscaped);
};
})
.filter('enableTechPreviewFeature', function(Constants) {
return function(feature) {
return _.get(Constants, ['ENABLE_TECH_PREVIEW_FEATURE', feature], false);
Expand Down
60 changes: 0 additions & 60 deletions app/scripts/services/html.js

This file was deleted.