Clarify GitHub webhook configuration #1660
Conversation
|
I found the instructions for adding a GitHub webhook to be lacking in this information, and only figured it out after trial and error. I believe that this additional information to be beneficial for users. |
There was a problem hiding this comment.
Thanks @wgordon17, definitely good to clarify this. Can you run grunt build to create the dist/ files and add them to your commit?
app/views/directives/next-steps.html
Outdated
| </span> | ||
| <span ng-if="!($ctrl.createdBuildConfig.spec.source.git.uri | isGithubLink)"> | ||
| Your source does not appear to be a URL to a GitHub repository. If you have a GitHub repository that you want to trigger this build from then use the following payload URL: | ||
| Your source does not appear to be a URL to a GitHub repository. If you have a GitHub repository that you want to trigger this build from then use the following payload URL and specifying a <i>Content type</i> of <mark>application/json</mark>: |
There was a problem hiding this comment.
We usually use code tags for things like <code>application/json</code>.
There was a problem hiding this comment.
Ok, that sounds reasonable. My thinking was since it wasn't actually code, I didn't want to confuse end users =)
wgordon17
force-pushed
the
provide-clearer-hook-instructions
branch
from
837ea0f
to
0f082ee
Compare
app/index.html
Outdated
| <script src="bower_components/objectpath/lib/ObjectPath.js"></script> | ||
| <script src="bower_components/angular-schema-form/dist/schema-form.js"></script> | ||
| <script src="bower_components/angular-schema-form/dist/bootstrap-decorator.js"></script> | ||
| <script src="bower_components/angular-schema-form-bootstrap/bootstrap-decorator.min.js"></script> |
There was a problem hiding this comment.
Looks like you have some diffs that shouldn't be here. Can you stop grunt serve and try
$ git checkout master app/index.html
$ bower install
$ grunt build
Then squash your commits?
There was a problem hiding this comment.
I thought it was odd as well. I didn't touch index.html, the changes came after running grunt build, so I assumed they were expected =P
There was a problem hiding this comment.
Yeah, your dependencies are out of date, which bower install will fix
wgordon17
force-pushed
the
provide-clearer-hook-instructions
branch
from
0f082ee
to
df3eed5
Compare
dist/scripts/vendor.js
Outdated
| @@ -8062,7 +8062,7 @@ delete c[b.id], delete d[a]; | |||
| http:80, | |||
| https:443, | |||
| ftp:21 | |||
| }, sf = b("$location"), tf = /^\s*[\\/]{2,}/, uf = { | |||
| }, sf = b("$location"), tf = /^\s*[\\\/]{2,}/, uf = { | |||
There was a problem hiding this comment.
This also looks incorrect :/ What node version do you have? Unfortunately anything newer than Node 4 generates slightly different dist output, which will cause merges to fail.
Probably easiest for now is to
$ git checkout master dist/scripts/vendor.js
since you only have markup changes.
There was a problem hiding this comment.
That was the easiest way, but I decided to go the "right" way and downgraded from Node8. Did I miss somewhere in the README about <= Node4 being a requirement?
There was a problem hiding this comment.
No, do you mind opening an issue? We either need to update the README or figure out what causes the diff with newer Node versions and fix it.
There was a problem hiding this comment.
Understood, thanks! =)
Signed-off-by: Will Gordon <wgordon@redhat.com>
wgordon17
force-pushed
the
provide-clearer-hook-instructions
branch
from
df3eed5
to
800920a
Compare
|
[merge] |
|
Evaluated for origin web console merge up to 800920a |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/1486/) (Base Commit: f70768f) |
Signed-off-by: Will Gordon wgordon@redhat.com