Show process template errors as toasts #1678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwforres
reviewed
Jun 12, 2017
| var hideNotificationErrors = function() { | ||
| NotificationsService.hideNotification("process-template-error"); | ||
| _.each(alerts, function(alert) { | ||
| if (alert.id) { |
There was a problem hiding this comment.
this assumes that we will only ever put id's on the error alerts, should this also check that the alert is a warning or error alert
spadgett
force-pushed
the
process-template-toasts
branch
from
e4f6047
to
def2450
Compare
|
@jwforres Thanks, updated. |
jwforres
reviewed
Jun 12, 2017
| @@ -80,6 +79,8 @@ | |||
| }; | |||
|
|
|||
| ctrl.close = function() { | |||
| $scope.$broadcast('hideTemplateNotificationErrors'); | |||
There was a problem hiding this comment.
assuming i'll need to do the same thing from my overlay PR then
There was a problem hiding this comment.
Yeah, and something similar is needed for from-file when #1677 goes in.
jwforres
approved these changes
Jun 12, 2017
|
[merge] |
|
Evaluated for origin web console merge up to def2450 |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/1494/) (Base Commit: cdf2198) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/6WVJdgjL