Remove calls to AlertMessageService.getAlerts() / clearAlerts() #1679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These methods are no longer needed since we are now showing toast notifications for alerts that cross page transitions.
jwforres
approved these changes
Jun 12, 2017
|
LGTM but should wait for the other toast PRs to all merge before tagging this one |
|
unless all the ones that removed refs to AlertsService are already merged |
|
#1677 is the last one |
This was referenced Jun 12, 2017
Remove AlertMessageService.addAlert() / getAlerts() / clearAlerts()
openshift/origin-web-catalog#278
Merged
|
should be good to [merge] now |
|
Evaluated for origin web console merge up to 9c8561b |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/1501/) (Base Commit: 513970c) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These methods are no longer needed since we are now showing toast notifications for alerts that cross page transitions.