Show application bindings on overview #1696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhamilto
reviewed
Jun 13, 2017
app/styles/_overview.less
Outdated
| @@ -81,6 +81,9 @@ | |||
| } | |||
| } | |||
| } | |||
| .service-binding h3 small { | |||
There was a problem hiding this comment.
Yeah I originally called it .application-binding and forgot to move when I renamed... Will fix.
rhamilto
reviewed
Jun 13, 2017
| @@ -81,30 +89,48 @@ | |||
| --> | |||
| <div class="row"> | |||
| <div class="col-sm-12" ng-if="row.description"> | |||
| <p class="pre-wrap" ng-bind-html="row.description | linky"></p> | |||
| <span class="pre-wrap" ng-bind-html="row.description | linky"></span> | |||
There was a problem hiding this comment.
Semantically, a paragraph is a better choice here.
jwforres
requested changes
Jun 13, 2017
app/scripts/controllers/overview.js
Outdated
| // Look at each pod preset selector to see if it covers this API object selector. | ||
| _.each(podPresetSelectors, function(podPresetSelector, bindingName) { | ||
| if (podPresetSelector.covers(applicationSelector)) { | ||
| // Keep a map of the traget UID to the binding and the binding to |
| <small>{{$ctrl.binding.spec.instanceRef.name}}</small> | ||
| </h3> | ||
| <h3 ng-if="!$ctrl.serviceClass"> | ||
| {{$ctrl.binding.metadata.name}} |
There was a problem hiding this comment.
think this was supposed to be updated to the instance name as well
Show what applications are bound to what provisioned services using pod presets.
spadgett
force-pushed
the
overview-bindings
branch
from
d32b871
to
d1fe7c3
Compare
|
Thanks updated |
jwforres
approved these changes
Jun 13, 2017
|
[merge] |
|
Evaluated for origin web console merge up to d1fe7c3 |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/1524/) (Base Commit: acdadd0) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/YRIHSS4W
Show what applications are bound to what provisioned services using pod presets.
cc @rhamilto @benjaminapetersen