Hide error notifications on $scope destroy, not just cancel #1706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jwforres I only updated the full page editors, not components in dialogs, to be safe. |
jwforres
approved these changes
Jun 14, 2017
|
[merge] |
|
@spadgett looks like a dist failure
…On Wed, Jun 14, 2017 at 10:47 AM, OpenShift Bot ***@***.***> wrote:
Origin Web Console Merge Results: FAILURE (https://ci.openshift.redhat.
com/jenkins/job/test_pull_requests_origin_web_console/1531/) (Base
Commit: a0ff009
<a0ff009>
)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1706 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABZk7b1PB4uWcQIjQn1M7lWKA7ihWhqyks5sD_J-gaJpZM4N57hN>
.
|
spadgett
force-pushed
the
hide-errors-scope-destroy
branch
2 times, most recently
from
55913d9
to
7ba3d6f
Compare
Hide error notifications for editors on $scope destroy rather than only in the cancel click handler. This will hide the notifications regardless of how the user navigates away (back button, etc.).
spadgett
force-pushed
the
hide-errors-scope-destroy
branch
from
7ba3d6f
to
13a8421
Compare
|
Evaluated for origin web console merge up to 13a8421 |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/1534/) (Base Commit: a0ff009) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hide error notifications for editors on $scope destroy rather than only
in the cancel click handler. This will hide the notifications regardless
of how the user navigates away (back button, etc.).